Add SERVICE_URL to override default service_url for Teams#247
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for customizing the Teams backend service URL through a SERVICE_URL environment variable and service_url configuration option, similar to the TypeScript SDK (teams.ts PR #435). This enables users to override the default service URL (https://smba.trafficmanager.net/teams) for regional deployments or testing scenarios.
Changes:
- Added
service_urloption toAppOptionsandInternalAppOptionsfor configuration flexibility - Implemented environment variable fallback with precedence: options > env > default
- Added comprehensive test coverage for all configuration scenarios
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/apps/src/microsoft_teams/apps/options.py | Added service_url field to AppOptions TypedDict and InternalAppOptions dataclass with documentation |
| packages/apps/src/microsoft_teams/apps/app.py | Implemented service URL resolution with rstrip("/") normalization and integrated with ApiClient initialization |
| packages/apps/tests/test_app.py | Added comprehensive test suite covering default, environment variable, options, and precedence scenarios |
lilyydu
approved these changes
Jan 26, 2026
heyitsaamir
added a commit
that referenced
this pull request
Jan 28, 2026
# Release version 2.0.0a9 Commits since v2.0.0a8: - Add support for Python 3.14 (#259) - Bump qs from 6.14.0 to 6.14.1 in /examples/tab/Web (#240) - Bump urllib3 from 2.5.0 to 2.6.3 (#251) - Bump authlib from 1.6.5 to 1.6.6 (#252) - Bump starlette from 0.48.0 to 0.49.1 (#261) - Bump fastmcp from 2.12.4 to 2.14.0 (#260) - Bump python-multipart from 0.0.20 to 0.0.22 (#254) - Bump virtualenv from 20.35.3 to 20.36.1 (#256) - Bump pyasn1 from 0.6.1 to 0.6.2 (#255) - Bump azure-core from 1.36.0 to 1.38.0 (#257) - Bump aiohttp from 3.13.0 to 3.13.3 (#258) - fix meetingStart and meetingEnd casing bug & add meetings sample (#246) - Remove jitter during streaming (#248) - Add SERVICE_URL to override default service_url for Teams (#247) - [Fix] streaming: do not reset timeout for each emit, do not wait forever on close stream (#197)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to microsoft/teams.ts#435. Need a way to override base URLs for the Teams backend.