Fix choices_data alias to use "choices.data" instead of "choicesData"#224
Merged
Conversation
Co-authored-by: heyitsaamir <[email protected]>
Copilot
AI
changed the title
[WIP] Update alias for choices_data in Cards package
Fix choices_data alias to use "choices.data" instead of "choicesData"
Nov 24, 2025
heyitsaamir
approved these changes
Nov 24, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the serialization alias for the choices_data field in ChoiceSetInput to use "choices.data" instead of the default camelCase "choicesData", ensuring compliance with the Adaptive Cards specification.
Key changes:
- Added special case handling for
choices_data→"choices.data"in both validation and serialization alias generators - Added comprehensive test coverage for serialization and deserialization round-trip
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/cards/src/microsoft/teams/cards/core.py | Added special alias handling for choices_data field in both validation_alias_generator and serialization_alias_generator methods, following the existing pattern used for ms_teams |
| packages/cards/tests/test_core_serialization.py | Added test test_choices_data_serializes_to_choices_dot_data() to verify proper serialization to "choices.data" and deserialization round-trip, plus imported necessary types |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Collaborator
|
|
when is the plan to merge it ? |
|
@heyitsaamir this will still fail on search with dataset that come form the app Because the app not support yeat 'application/search when i added the missing types is work well 🚀 we can extend the on_invoke event |
Collaborator
Thanks @aviadpriel ! Would you mind putting up a PR with that? @aacebo iirc you had added this somewhere right? |
lilyydu
approved these changes
Nov 26, 2025
Merged
heyitsaamir
added a commit
that referenced
this pull request
Dec 9, 2025
## Release 2.0.0a7 ### Changes - update react and react-dom to 19.2.1 (#233) - Move to microsoft_teams namespace (#226) - Simplify setting http response after activity processing (#218) - Add TeamsChannelAccount type for Teams-specific APIs (#230) - Updating mcpplugin reference in README.md (#229) - Bring back bot builder example (#225) - Fix choices_data alias to use "choices.data" instead of "choicesData" (#224) - [docs] botbuilder package README fixes (#223) - Fix calling AI functions with no parameters (#221)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
choices_datafield inChoiceSetInputwas incorrectly serializing to"choicesData"(default camelCase) instead of"choices.data"per the Adaptive Cards spec.Changes
SerializableObject.validation_alias_generatorandserialization_alias_generatorforchoices_data→"choices.data"Example
Follows existing pattern for
ms_teams→"msteams".Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
login.microsoftonline.com/home/REDACTED/work/teams.py/teams.py/.venv/bin/pytest pytest packages -x(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.