Simplify setting http response after activity processing #218
Merged
Conversation
Collaborator
|
Now that we aren't using events for responses, I think we should make these fundamental changes:
|
singhk97
marked this pull request as ready for review
November 21, 2025 21:06
Contributor
Author
|
Refactored the activity processor out of the event manager and into the plugin processor. |
singhk97
changed the title
2 tasks
heyitsaamir
reviewed
Nov 21, 2025
lilyydu
reviewed
Nov 24, 2025
singhk97
commented
Dec 1, 2025
Contributor
Author
|
So it turns out that the error event is not even being emitted if an exception is raised by one of the handlers. I've pushed a commit to a fix that. The behavior is now: 
for 
(apologies for confusing error message) |
…/microsoft/teams.py into kavin/simplify-activity-response
singhk97
commented
Dec 4, 2025
Merged
heyitsaamir
pushed a commit
to microsoft/teams.ts
that referenced
this pull request
Dec 9, 2025
fixes #393 The returned `{ status: 200 }` from `app.$process` is not handled by the plugin, and so the http response is not set causing the server to "hang". By not short circuiting, the program execution continues leading to `onActivityResponse` event being called and the HTTP response being set to default status of 200. - [x] **Is it an issue in .NET SDK?** Nope, there is no short-circuiting being done like this. - [x] **Is it an issue in Python SDK?** Yes, it should be fixed: microsoft/teams.py#218
heyitsaamir
added a commit
that referenced
this pull request
Dec 9, 2025
## Release 2.0.0a7 ### Changes - update react and react-dom to 19.2.1 (#233) - Move to microsoft_teams namespace (#226) - Simplify setting http response after activity processing (#218) - Add TeamsChannelAccount type for Teams-specific APIs (#230) - Updating mcpplugin reference in README.md (#229) - Bring back bot builder example (#225) - Fix choices_data alias to use "choices.data" instead of "choicesData" (#224) - [docs] botbuilder package README fixes (#223) - Fix calling AI functions with no parameters (#221)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked PR: microsoft/teams.ts#398
This is how the architecture looked like before
This is what it looks like now: