Remove ExperimentalTeamsQuotedReplies markers#572
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR promotes quoted replies to GA by removing all ExperimentalTeamsQuotedReplies markers across the SDK, including API attributes, compiler warning suppressions, and project-level NoWarn entries, and updating migration documentation accordingly.
Changes:
- Removed
[Experimental("ExperimentalTeamsQuotedReplies")]from public APIs and related types. - Removed
#pragma warning disable/restore ExperimentalTeamsQuotedRepliesblocks and cleanedNoWarnentries in project files. - Updated
core/docs/MigrationGuide.mdto reflect quoted replies no longer being experimental.
Reviewed changes
Copilot reviewed 16 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/Microsoft.Teams.Apps.Tests/Microsoft.Teams.Apps.Tests.csproj | Drops ExperimentalTeamsQuotedReplies from test project warning suppressions. |
| Tests/Microsoft.Teams.Api.Tests/Microsoft.Teams.Api.Tests.csproj | Drops ExperimentalTeamsQuotedReplies from test project warning suppressions. |
| Samples/Samples.Quoting/Samples.Quoting.csproj | Removes quoted-replies experimental NoWarn from the sample project. |
| Libraries/Microsoft.Teams.Apps/Contexts/Context.Send.cs | Removes experimental attributes/pragma suppressions from quoting/replying context APIs. |
| Libraries/Microsoft.Teams.Apps/Activities/Conversations/ConversationEndActivity.cs | Keeps CS0618 suppression but normalizes pragma placement (no quoted-replies markers involved). |
| Libraries/Microsoft.Teams.Api/Entities/QuotedReplyEntity.cs | Removes [Experimental] from quoted reply entity types. |
| Libraries/Microsoft.Teams.Api/Entities/Entity.cs | Removes quoted-replies warning suppressions in entity JSON conversion paths. |
| Libraries/Microsoft.Teams.Api/Activities/Message/MessageActivity.cs | Removes experimental markers/suppressions from quoted reply helpers on MessageActivity. |
| Libraries/Microsoft.Teams.Api/Activities/Activity.JsonConverter.cs | Retains CS0618 suppression for EndOfConversationActivity converter paths. |
| Libraries/Microsoft.Teams.Api/Activities/Activity.cs | Retains CS0618 suppression where obsolete members are still referenced. |
| Libraries/Microsoft.Teams.Api/Activities/Activity.Convertible.cs | Retains CS0618 suppression in convertible implementation for end-of-conversation conversion. |
| core/test/Microsoft.Teams.Apps.UnitTests/Microsoft.Teams.Apps.UnitTests.csproj | Drops ExperimentalTeamsQuotedReplies from unit test project warning suppressions. |
| core/src/Microsoft.Teams.Apps/Schema/TeamsActivityBuilder.cs | Removes [Experimental] from AddQuote builder API. |
| core/src/Microsoft.Teams.Apps/Schema/MessageActivityExtensions.cs | Removes [Experimental] from quote-related extension methods. |
| core/src/Microsoft.Teams.Apps/Schema/Entities/QuotedReplyEntity.Extensions.cs | Removes [Experimental] from quoted reply entity extension methods. |
| core/src/Microsoft.Teams.Apps/Schema/Entities/QuotedReplyEntity.cs | Removes [Experimental] from core quoted reply entity/data types. |
| core/src/Microsoft.Teams.Apps/Microsoft.Teams.Apps.csproj | Removes ExperimentalTeamsQuotedReplies from package project NoWarn. |
| core/src/Microsoft.Teams.Apps/Context.cs | Removes [Experimental] from Context.Quote(...) overloads. |
| core/samples/Quoting/Quoting.csproj | Removes quoted-replies experimental NoWarn from the core quoting sample. |
| core/docs/MigrationGuide.md | Updates migration docs to reflect quoted replies being GA (no longer experimental). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
heyitsaamir
approved these changes
Jun 16, 2026
corinagum
added a commit
to microsoft/teams-sdk
that referenced
this pull request
Jun 16, 2026
## Summary Documentation updates driven by customer feedback ([Discussion #2881](#2881), [Issue #2871](#2871)). Fixes #2871 ## SSO Documentation (new content) - **SSO with User-Assigned Managed Identity**: New section in `sso-setup.mdx` explaining how IDs map when the bot uses MI and a separate auth app registration - **Cross-Tenant Considerations**: New section covering tenant requirements for SSO to work silently - **`authrequestfailed` troubleshooting**: New section in `troubleshooting-sso.mdx` for cross-tenant SSO failures - **OAuth card fallback and magic code**: Documents when/why the magic code appears and the `signin()` + `app.event('signin')` pattern ## Preview Status Updates - Targeted messages: "coming soon in May 2026" -> "available in public preview" - Slash commands: same update - Quoted replies: removed "Coming Soon" callout (now GA) - Removed C# experimental note for quoted replies (`ExperimentalTeamsQuotedReplies` being removed in companion PRs) ## Companion PRs - microsoft/teams.ts#621 - microsoft/teams.py#470 - microsoft/teams.net#572 --------- Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quoted replies are now GA. Removes all
[Experimental("ExperimentalTeamsQuotedReplies")]attributes,#pragma warning disable/restorepairs, andNoWarnentries from csproj files.Changes
Across both
Libraries/andcore/:[Experimental]attributes from classes and methodsNoWarnentries in csproj files (preserving other warnings likeExperimentalTeamsTargeted)core/docs/MigrationGuide.mdAll tests pass (696/696). Format check passes.