Fix fluent API regression and documentation for WithRecipient overloads#320
Merged
Conversation
…on test Co-authored-by: rido-min <[email protected]>
rido-min
marked this pull request as ready for review
February 11, 2026 15:17
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Refactor targeted messages with overload in WithRecipient
Fix fluent API regression and documentation for WithRecipient overloads
Feb 11, 2026
rido-min
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses four issues from PR review feedback where the
WithRecipientAPI refactoring introduced a fluent chaining regression, incorrect error messaging, and outdated documentation.Fluent API fix:
MessageActivity.WithRecipient(Account)override returningMessageActivityto preserve fluent chaining when calling the 1-arg overloadnew MessageActivity().WithRecipient(account)resolved to base class method and returnedActivity, breaking chains like.WithRecipient(account).AddText(...)Error message correction:
App.csfromWithRecipient(recipientId, true)toWithRecipient(new Account { Id = recipientId }, true)to reflect actual parameter typesDocumentation updates:
WithTargetedRecipientreferences in README comparison table with currentWithRecipientAPITest coverage:
WithRecipient_MaintainsFluentChainingtest that chains.AddText()after.WithRecipient()to catch future regressions💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.