Fix unsafe IApplicationBuilder→WebApplication cast by moving endpoint registration to UseTeams#287
Merged
Merged
Conversation
Co-authored-by: rido-min <[email protected]>
Co-authored-by: rido-min <[email protected]>
Copilot
AI
changed the title
[WIP] WIP to address feedback on deprecating Teams Controllers
Replace unsafe IApplicationBuilder→WebApplication cast with UseEndpoints pattern
Jan 27, 2026
Contributor
|
@copilot with this PR the request is not executed, I got this from the logs |
…orization Co-authored-by: rido-min <[email protected]>
Co-authored-by: rido-min <[email protected]>
Contributor
Author
... Fixed in commit 8226754. The issue was middleware ordering - I was registering the endpoint before UseAuthorization() was called, causing authorization to fail. The endpoint is now registered in the UseTeams method's UseEndpoints call, ensuring proper ordering: UseRouting → UseAuthorization → UseEndpoints. This also eliminates the unsafe cast to WebApplication. |
Copilot
AI
changed the title
Replace unsafe IApplicationBuilder→WebApplication cast with UseEndpoints pattern
Fix unsafe IApplicationBuilder→WebApplication cast by moving endpoint registration to UseTeams
Jan 27, 2026
Cleaned up imports by removing unused static and type alias directives, improving code clarity and maintainability.
rido-min
approved these changes
Jan 27, 2026
rido-min
marked this pull request as ready for review
January 27, 2026 15:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AspNetCorePlugin.Configuremethod was castingIApplicationBuildertoWebApplication, which throws if the builder isn't aWebApplicationinstance. WhileIApplicationBuilderis typically aWebApplicationin standard ASP.NET Core apps, the interface contract doesn't guarantee this.Problem
The original implementation had two issues:
IApplicationBuildertoWebApplicationSolution
Moved endpoint registration from
AspNetCorePlugin.Configureto theUseTeamsextension method inApplicationBuilder.cs, where proper ASP.NET Core middleware ordering is maintained.Changes
AspNetCorePlugin.cs:
ApplicationBuilder.cs:
Before:
After:
This approach:
IApplicationBuilderimplementation💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.