Fthakor/api package clients tests#14
Merged
aacebo merged 10 commits intoMay 15, 2025
Merged
Conversation
fallothakor
commented
May 14, 2025
fallothakor
commented
May 14, 2025
fallothakor
commented
May 14, 2025
added 5 commits
May 14, 2025 07:54
aacebo
reviewed
May 14, 2025
| var req = HttpRequest.Post($"https://token.botframework.com/api/usertoken/GetAadTokens?{query}", body: request); | ||
| var res = await _http.SendAsync<IDictionary<string, TokenResponse>>(req, _cancellationToken); | ||
| var res = await _http.SendAsync<IDictionary<string, Token.Response>>(req, _cancellationToken); | ||
| return (IDictionary<string, Token.Response>)res.Body; |
Collaborator
There was a problem hiding this comment.
do we still need this cast?
Collaborator
Author
There was a problem hiding this comment.
no we dont, wanted to confirm the change first.
aacebo
approved these changes
May 15, 2025
corinagum
added a commit
that referenced
this pull request
May 5, 2026
Per team decision, the MCP client SSRF guard adds friction for legitimate on-prem MCP customers and the underlying risk is low-likelihood. Reverting the client-side URL validation work; the McpPlugin server auth (#14), including the null-safe Logger fix, is kept. Removes: - UrlValidation.cs (and tests) - McpClientPluginParams.AllowPrivateNetwork + ValidateUrl - ValidateMcpServerUrlAsync calls in McpClientPlugin
corinagum
added a commit
that referenced
this pull request
May 6, 2026
Per team decision, the MCP client SSRF guard adds friction for legitimate on-prem MCP customers and the underlying risk is low-likelihood. Reverting the client-side URL validation work; the McpPlugin server auth (#14), including the null-safe Logger fix, is kept. Removes: - UrlValidation.cs (and tests) - McpClientPluginParams.AllowPrivateNetwork + ValidateUrl - ValidateMcpServerUrlAsync calls in McpClientPlugin
corinagum
added a commit
that referenced
this pull request
May 6, 2026
Per team decision, the MCP client SSRF guard adds friction for legitimate on-prem MCP customers and the underlying risk is low-likelihood. Reverting the client-side URL validation work; the McpPlugin server auth (#14), including the null-safe Logger fix, is kept. Removes: - UrlValidation.cs (and tests) - McpClientPluginParams.AllowPrivateNetwork + ValidateUrl - ValidateMcpServerUrlAsync calls in McpClientPlugin
corinagum
added a commit
that referenced
this pull request
May 11, 2026
Per team decision, the MCP client SSRF guard adds friction for legitimate on-prem MCP customers and the underlying risk is low-likelihood. Reverting the client-side URL validation work; the McpPlugin server auth (#14), including the null-safe Logger fix, is kept. Removes: - UrlValidation.cs (and tests) - McpClientPluginParams.AllowPrivateNetwork + ValidateUrl - ValidateMcpServerUrlAsync calls in McpClientPlugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.