Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Minor ui improvements, better column sizing, selectable text#127

Merged
samiyaakhtar merged 3 commits intomasterfrom
1200
Jun 2, 2020
Merged

Minor ui improvements, better column sizing, selectable text#127
samiyaakhtar merged 3 commits intomasterfrom
1200

Conversation

@samiyaakhtar
Copy link
Contributor

  • Shimmer is now two-line table, better representing how the table displays when it's loaded
  • Made text in table selectable
  • Switch from fixed width to proportional width for better real estate utilization
    • Note: The table does not size columns according to dynamic content, our only options are fixed and proportional width.
      Screen Shot 2020-05-14 at 10 36 38 AM

http://52.149.54.124:5000/

Closes microsoft/bedrock#1200

@andrebriggs
Copy link
Member

Looks fine to me. I'm interested in @gemorris opinion on proportional width changes

@gemorris
Copy link

This looks good, a few notes but nothing critical.

  1. the ... truncation pattern does not seem to be applying to sub-items like the "hellobedrock2019-hellobedrock.acme.frontend:master-20200524.1" Not sure if this was an oversight or intentional. I'd like to be consistent if possible with our truncation.
  2. the fact that the row highlights when I hover, and that we don't have distinct styles for clickable items (only distinct hover styles) is definitely creating some interaction-uncertainty in my mind. The hover state on the row is something I'd like to talk about, as it usually indicates that clicking the row will do something / navigate somewhere. Maybe we don't need it? We do need a more clear style for clickable items but I don't have an answer for that right now, will make a note to try some options though.

All that said I think it is shippable as-is, but would like to try removing the row hover if it is quick, just to remove one potential source of confusion from the UI.

@samiyaakhtar
Copy link
Contributor Author

@gemorris Just fixed the truncation pattern on the sub-items. As for the row hover, I'll make a separate issue and PR that in a future update, as I haven't found a fix for this one just yet.

Updated http://52.149.54.124:5000/ with the changes.

@samiyaakhtar samiyaakhtar merged commit 25d17f7 into master Jun 2, 2020
@samiyaakhtar samiyaakhtar deleted the 1200 branch June 2, 2020 21:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spk dashboard columns should resize and adjust width

4 participants