This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Minor ui improvements, better column sizing, selectable text#127
Merged
samiyaakhtar merged 3 commits intomasterfrom Jun 2, 2020
Merged
Minor ui improvements, better column sizing, selectable text#127samiyaakhtar merged 3 commits intomasterfrom
samiyaakhtar merged 3 commits intomasterfrom
Conversation
Member
|
Looks fine to me. I'm interested in @gemorris opinion on proportional width changes |
andrebriggs
approved these changes
May 15, 2020
|
This looks good, a few notes but nothing critical.
All that said I think it is shippable as-is, but would like to try removing the row hover if it is quick, just to remove one potential source of confusion from the UI. |
Contributor
Author
|
@gemorris Just fixed the truncation pattern on the sub-items. As for the row hover, I'll make a separate issue and PR that in a future update, as I haven't found a fix for this one just yet. Updated http://52.149.54.124:5000/ with the changes. |
evanlouie
approved these changes
Jun 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://52.149.54.124:5000/
Closes microsoft/bedrock#1200