Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Introducing caching in backend and consuming in frontend#121

Merged
samiyaakhtar merged 22 commits intomasterfrom
backendCaching
Apr 29, 2020
Merged

Introducing caching in backend and consuming in frontend#121
samiyaakhtar merged 22 commits intomasterfrom
backendCaching

Conversation

@samiyaakhtar
Copy link
Contributor

@samiyaakhtar samiyaakhtar commented Apr 24, 2020

  • Removed author, PR, cluster sync endpoints, since this information is now cached within deployment object (this simplified frontend logic)
  • Dennis has introduced caching libs and logic for updating and purging cache, along with unit tests

Deployed at: http://52.149.54.124:5000/

Closes microsoft/bedrock#1318
Closes microsoft/bedrock#1090

@samiyaakhtar samiyaakhtar marked this pull request as ready for review April 24, 2020 23:18
Copy link
Collaborator

@dennisseah dennisseah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any plan to implement caching for clustersync?

@samiyaakhtar
Copy link
Contributor Author

any plan to implement caching for clustersync?

@dennisseah implemented, it's part of the main deployments api response. Please take a look and provide feedback :)

@dennisseah
Copy link
Collaborator

any plan to implement caching for clustersync?

@dennisseah implemented, it's part of the main deployments api response. Please take a look and provide feedback :)

Thanks Samiya. do we have to make clustersync calls for every updates? that's is there a way to figure out that nothing is changed and we do not need to make the call?

@samiyaakhtar
Copy link
Contributor Author

@dennisseah Thanks, just added more improvements around cluster sync

@samiyaakhtar samiyaakhtar requested a review from dennisseah April 28, 2020 19:09
Copy link
Collaborator

@dennisseah dennisseah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks

@samiyaakhtar samiyaakhtar merged commit 6b588da into master Apr 29, 2020
@samiyaakhtar samiyaakhtar deleted the backendCaching branch April 29, 2020 17:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboard should utilize caching in front end Dashboard needs caching support

3 participants