Repository navigation
Python: FunctionResultContent hash fix to handle lists/sets - #9978
Merged
Merged
Conversation
Eduard van Valkenburg (eavanvalkenburg)
approved these changes
Dec 16, 2024
Eduard van Valkenburg (eavanvalkenburg)
left a comment
Member
There was a problem hiding this comment.
small note
Contributor
Python Test Coverage Report •
Python Unit Test Overview
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Eduard van Valkenburg (eavanvalkenburg)
approved these changes
Dec 16, 2024
Tao Chen (TaoChenOSU)
approved these changes
Dec 16, 2024
Evan Mattson (moonbox3)
enabled auto-merge
December 16, 2024 22:07
Tao Chen (TaoChenOSU)
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently, the hash function in
FunctionResultContentdoes not properly handle types of list or set. Adding the proper handling to turn these into a tuple, and then the hash function works properly.Description
This PR:
__hash__method can properly handle mutable types like lists or setsContribution Checklist