Repository navigation
.Net: Fixed JSON schema name in Structured Outputs for generic types - #9490
Merged
Dmytro Struk (dmytrostruk) merged 7 commits intoNov 1, 2024
Merged
Dmytro Struk (dmytrostruk) merged 7 commits into
Dmytro Struk (dmytrostruk) merged 7 commits into
Conversation
Mark Wallace (markwallace-microsoft)
added
.NET
Dmytro Struk (dmytrostruk)
temporarily deployed
to
integration
October 31, 2024 18:08 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
westey (westey-m)
approved these changes
Oct 31, 2024
Dmytro Struk (dmytrostruk)
temporarily deployed
to
integration
October 31, 2024 20:36 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
|
Wouldn't it better to use fully qualified type names, as they are truly unique, and because OpenAI doesn't support symbols, use for example hash of string? |
Dmytro Struk (dmytrostruk)
temporarily deployed
to
integration
November 1, 2024 15:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Dmytro Struk (dmytrostruk)
had a problem deploying
to
integration
November 1, 2024 17:08 — with
GitHub Actions
Error
GitHub Actions
Error
Member
Author
Aleksandr Vishniakov (@asvishnyakov) Thanks for your feedback! I don't see a requirement for this property to be unique in OpenAI docs or usage of hash in their examples. It would be also nice to be consistent with Python implementation, which uses just a name. |
Dmytro Struk (dmytrostruk)
temporarily deployed
to
integration
November 1, 2024 17:11 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Dmytro Struk (dmytrostruk)
temporarily deployed
to
integration
November 1, 2024 18:35 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Mark Wallace (markwallace-microsoft)
approved these changes
Nov 1, 2024
Dmytro Struk (dmytrostruk)
deleted the
structured-outputs-schema-name-fix
branch
November 1, 2024 19:05
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Resolves: #9416
When C# type is passed as a response format to OpenAI chat completion service, we use the type name as JSON schema name. When the type is generic, its name will contain characters that are not allowed in JSON schema name according to OpenAI API. This PR fixes the issue by replacing invalid characters with empty string.
Contribution Checklist