Skip to content

.Net: Processes State Management Part 2 - #9481

Merged
Estefanía Tenorio (esttenorio) merged 27 commits into
microsoft:mainfrom
esttenorio:estenori/processes-state-management
Nov 5, 2024
Merged

.Net: Processes State Management Part 2#9481
Estefanía Tenorio (esttenorio) merged 27 commits into
microsoft:mainfrom
esttenorio:estenori/processes-state-management

Conversation

@esttenorio

@esttenorio Estefanía Tenorio (esttenorio) commented Oct 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • Moving ProcessStateMetadata logic to factory/extension to try to keep clean existing core components
  • Adding check of step name when adding new steps/processes to process - names must be unique so when applying saved state it propagates properly. Currently there are issues if multiple steps have the same name
  • State versioning initial support:
    • Processes with 1:1 step match previous and new version (step name change and/or step logic change) - minor changes on process steps and not in root process itself

Fixing #9358

Out of scope but will be addressed in next PRs

  • Processes with N:M steps (process flow changed and potentially also step logic changed)
  • New samples showcasing how to make use of N:M mapping

Contribution Checklist

@markwallace-microsoft Mark Wallace (markwallace-microsoft) added the .NET Issue or Pull requests regarding .NET code label Oct 30, 2024
@github-actions github-actions Bot changed the title Processes State Management Part 2 .Net: Processes State Management Part 2 Oct 30, 2024
@esttenorio
Estefanía Tenorio (esttenorio) marked this pull request as ready for review November 2, 2024 01:35
@crickman
Chris (crickman) self-requested a review November 4, 2024 18:43
@alliscode

Ben Thomas (alliscode) commented Nov 4, 2024

Copy link
Copy Markdown
Member

I really like the centralized serialization logic. I'll be able to integrate this to the map-step change much more easily.

I like the depth with which the Step03 sample was updated, but I wonder if there isn't an opportunity for a more targeted starting point to introduce the serialization patterns. Demonstrating these patterns is a more real case is wonderful evidence on how these patterns scale-out...but I wonder if a more simple sample that only targets serialization and versioning would be useful.

I agree but I wonder if the learn site is the place for this tutorial style walkthrough?

@crickman

Chris (crickman) commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

I really like the centralized serialization logic. I'll be able to integrate this to the map-step change much more easily.
I like the depth with which the Step03 sample was updated, but I wonder if there isn't an opportunity for a more targeted starting point to introduce the serialization patterns. Demonstrating these patterns is a more real case is wonderful evidence on how these patterns scale-out...but I wonder if a more simple sample that only targets serialization and versioning would be useful.

I agree but I wonder if the learn site is the place for this tutorial style walkthrough?

Sure, or both

@crickman
Chris (crickman) self-requested a review November 5, 2024 18:29
Merged via the queue into microsoft:main with commit a7a56e5 Nov 5, 2024
@esttenorio
Estefanía Tenorio (esttenorio) deleted the estenori/processes-state-management branch November 5, 2024 18:51

This branch was previously deployed

1 inactive deployment
integration — c8ade0f5 Deployed Nov 5, 2024 by esttenorio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alliscode Ben Thomas (alliscode) alliscode approved these changes
+1 more reviewer
@crickman Chris (crickman) crickman approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation .NET Issue or Pull requests regarding .NET code processes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@esttenorio @alliscode @crickman @markwallace-microsoft