Repository navigation
Update System.Text.Json and enable transitive pinning - #938
Merged
Lee Miller (lemillermicrosoft) merged 4 commits intoMay 11, 2023
Merged
Conversation
Lee Miller (lemillermicrosoft)
changed the title
Lee Miller (lemillermicrosoft)
marked this pull request as ready for review
May 11, 2023 05:01
Lee Miller (lemillermicrosoft)
marked this pull request as draft
May 11, 2023 05:03
Lee Miller (lemillermicrosoft)
force-pushed
the
510_newton
branch
from
May 11, 2023 05:08
108ec0f to
611e4aa
Compare
Lee Miller (lemillermicrosoft)
changed the title
Lee Miller (lemillermicrosoft)
marked this pull request as ready for review
May 11, 2023 05:09
Lee Miller (lemillermicrosoft)
marked this pull request as draft
May 11, 2023 05:12
This commit updates the System.Text.Json package version to 7.0.0 and enables the CentralPackageTransitivePinningEnabled property in the Directory.Packages.props file. This property allows the central package management feature to pin the versions of transitive dependencies to the ones specified in the props file, avoiding potential conflicts or inconsistencies. This change improves the reliability and maintainability of the dotnet projects that use the Directory.Packages.props file.
Lee Miller (lemillermicrosoft)
force-pushed
the
510_newton
branch
from
May 11, 2023 05:16
611e4aa to
6c2fffe
Compare
Lee Miller (lemillermicrosoft)
marked this pull request as ready for review
May 11, 2023 05:16
Lee Miller (lemillermicrosoft)
changed the title
The test ReadFromJsonThrowsWithInvalidJson was passing an invalid JSON string to the JsonSerializer.Deserialize method, which was expected to throw a JsonException. However, the method actually throws an ArgumentNullException when the input is null or empty. This commit fixes the test by passing a null string instead of an invalid one, and updating the expected exception type. It also adds a pragma directive to suppress the JSON001 warning for the invalid JSON string.
github-actions
Bot
added
.NET
Shawn Callegari (shawncal)
approved these changes
May 11, 2023
Lee Miller (lemillermicrosoft)
enabled auto-merge (squash)
May 11, 2023 13:25
Adrian Bonar (adrianwyatt)
added a commit
that referenced
this pull request
May 11, 2023
Shawn Callegari (shawncal)
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
May 19, 2023
This commit updates the System.Text.Json package version to 7.0.0 and enables the CentralPackageTransitivePinningEnabled property in the Directory.Packages.props file. This property allows the central package management feature to pin the versions of transitive dependencies to the ones specified in the props file, avoiding potential conflicts or inconsistencies. This change improves the reliability and maintainability of the dotnet projects that use the Directory.Packages.props file. The test ReadFromJsonThrowsWithInvalidJson was passing an invalid JSON string to the JsonSerializer.Deserialize method, which was expected to throw a JsonException. However, the method actually throws an ArgumentNullException in System.Text.Json 7.0.0 when the named property is missing. This commit fixes the test by updating the expected exception type. It also adds a pragma directive to suppress the JSON001 warning for the invalid JSON string. [Central Package Management | Microsoft Learn](https://learn.microsoft.com/en-us/nuget/consume-packages/Central-Package-Management) [Update dependencies | Docs - Microsoft Open Source](https://docs.opensource.microsoft.com/tools/cg/how-to/updating-dependencies/#nuget)
Shawn Callegari (shawncal)
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
May 19, 2023
…oft#938)" (microsoft#955) This reverts commit 7573efb.
Desmond Howard (dehoward)
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
This commit updates the System.Text.Json package version to 7.0.0 and enables the CentralPackageTransitivePinningEnabled property in the Directory.Packages.props file. This property allows the central package management feature to pin the versions of transitive dependencies to the ones specified in the props file, avoiding potential conflicts or inconsistencies. This change improves the reliability and maintainability of the dotnet projects that use the Directory.Packages.props file. The test ReadFromJsonThrowsWithInvalidJson was passing an invalid JSON string to the JsonSerializer.Deserialize method, which was expected to throw a JsonException. However, the method actually throws an ArgumentNullException in System.Text.Json 7.0.0 when the named property is missing. This commit fixes the test by updating the expected exception type. It also adds a pragma directive to suppress the JSON001 warning for the invalid JSON string. [Central Package Management | Microsoft Learn](https://learn.microsoft.com/en-us/nuget/consume-packages/Central-Package-Management) [Update dependencies | Docs - Microsoft Open Source](https://docs.opensource.microsoft.com/tools/cg/how-to/updating-dependencies/#nuget)
Desmond Howard (dehoward)
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
…oft#938)" (microsoft#955) This reverts commit 8b666e1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the System.Text.Json package version to 7.0.0 and enables the CentralPackageTransitivePinningEnabled property in the Directory.Packages.props file. This property allows the central package management feature to pin the versions of transitive dependencies to the ones specified in the props file, avoiding potential conflicts or inconsistencies. This change improves the reliability and maintainability of the dotnet projects that use the Directory.Packages.props file.
The test ReadFromJsonThrowsWithInvalidJson was passing an invalid JSON string to the JsonSerializer.Deserialize method, which was expected to throw a JsonException. However, the method actually throws an ArgumentNullException in System.Text.Json 7.0.0 when the named property is missing. This commit fixes the test by updating the expected exception type. It also adds a pragma directive to suppress the JSON001 warning for the invalid JSON string.
Central Package Management | Microsoft Learn
Update dependencies | Docs - Microsoft Open Source
Contribution Checklist
dotnet format