Repository navigation
Fixed this notebook automatically resetting the bool to false - #935
Merged
Merged
Conversation
github-actions
Bot
added
.NET
This notebook doesn't highlight that the bool is set back to false even if the user changed it to true in the previous 0-AI-settings notebook
Shawn Callegari (shawncal)
force-pushed
the
patch-2
branch
from
May 18, 2023 04:26
5e9be74 to
d53e395
Compare
Adrian Bonar (adrianwyatt)
requested review from
Devis Lucato (dluc)
and removed request for
Adrian Bonar (adrianwyatt)
May 18, 2023 22:59
Devis Lucato (dluc)
assigned
Devis Lucato (dluc) and unassigned
Adrian Bonar (adrianwyatt)
Devis Lucato (dluc)
approved these changes
May 18, 2023
Shawn Callegari (shawncal)
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
May 19, 2023
…oft#935) This notebook doesn't highlight that the bool is set back to false even if the user changed it to true in the previous 0-AI-settings notebook ### Motivation and Context 1. Why is this change required? By setting bool useAzureOpenAI = false here, we are resetting the user's initial input in the first notebook. This results in downstream errors. We need to tell the user to set it as the same vaLue they used in the previous notebook. 2. What problem does it solve? It solves the problem of resetting the AzureOpenAI bool to false after the user set it to true. ### Description It is already set in the first file 00-getting-started. By setting it to false here, we are resetting the user's previous input resulting in errors in later notebooks. It is honestly a bit weird that the same steps are repeated, it should be in one or other notebook no? Co-authored-by: Devis Lucato <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This notebook doesn't highlight that the bool is set back to false even if the user changed it to true in the previous 0-AI-settings notebook
Motivation and Context
Description
It is already set in the first file 00-getting-started. By setting it to false here, we are resetting the user's previous input resulting in errors in later notebooks. It is honestly a bit weird that the same steps are repeated, it should be in one or other notebook no?
Contribution Checklist
dotnet format