Repository navigation
.Net: Map OpenAPI parameter type to KernelParameterMetadata - #8198
Merged
SergeyMenshykh merged 5 commits intoAug 16, 2024
Merged
SergeyMenshykh merged 5 commits into
SergeyMenshykh merged 5 commits into
Conversation
westey (westey-m)
approved these changes
Aug 16, 2024
Dmytro Struk (dmytrostruk)
approved these changes
Aug 16, 2024
SergeyMenshykh
enabled auto-merge
August 16, 2024 18:11
Mark Wallace (markwallace-microsoft)
approved these changes
Aug 16, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
…t#8198) ### Motivation, Context and Description Today, the OpenAPI functionality that maps the data type of a parameter from the OpenAPI spec to `KernelParameterMetadata` supports only the mapping for string and boolean types. This PR extends the mapping to support other primitive types like `number`, `integer`, and `object`. Closes: microsoft#8182 Out of scope: - Support for the `array` data type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation, Context and Description
Today, the OpenAPI functionality that maps the data type of a parameter from the OpenAPI spec to
KernelParameterMetadatasupports only the mapping for string and boolean types. This PR extends the mapping to support other primitive types likenumber,integer, andobject.Closes: #8087
Out of scope:
arraydata type.