Repository navigation
.Net Agents - ChatCompletionAgent Pre-Graduation - #7900
Merged
Merged
Conversation
Chris (crickman)
requested review from
Ben Thomas (alliscode),
Mads Bolaris (madsbolaris) and
Evan Mattson (moonbox3)
August 7, 2024 16:51
Chris (crickman)
marked this pull request as ready for review
August 7, 2024 20:35
Ben Thomas (alliscode)
approved these changes
Aug 8, 2024
Ben Thomas (alliscode)
approved these changes
Aug 8, 2024
Evan Mattson (moonbox3)
approved these changes
Aug 8, 2024
Chris (crickman)
enabled auto-merge
August 8, 2024 18:06
Evan Mattson (moonbox3)
approved these changes
Aug 8, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Update public signatures / interface of `ChatCompletionAgent` in preparation for removing experimental tag. Fixes: microsoft#6037 Fixes: microsoft#6523 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> - Include `Kernel` and `KernelArguments` in agent invocation signatures for `ChatCompletionAgent` - Change `ChatCompletionAgent.ExeuctionSettings` to `ChatCompletionAgent.KernelArguments` - Mirror pattern for `OpenAIAssistantAgent` - Integrate `Kernel` and `KernelArguments.ExecutionSettings` as overrides for agent invocation - Added new sample that explores the entire selection matrix: `ChatCompletion_ServiceSelection` ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Update public signatures / interface of
ChatCompletionAgentin preparation for removing experimental tag.Fixes: #6037
Fixes: #6523
Description
KernelandKernelArgumentsin agent invocation signatures forChatCompletionAgentChatCompletionAgent.ExeuctionSettingstoChatCompletionAgent.KernelArgumentsOpenAIAssistantAgentKernelandKernelArguments.ExecutionSettingsas overrides for agent invocationChatCompletion_ServiceSelectionContribution Checklist