Skip to content

.Net Agents - ChatCompletionAgent Pre-Graduation - #7900

Merged
Chris (crickman) merged 16 commits into
mainfrom
feature_agent_chat_finals
Aug 8, 2024
Merged

Chris (crickman) merged 16 commits into
mainfrom
feature_agent_chat_finals

Conversation

@crickman

@crickman Chris (crickman) commented Aug 6, 2024 •

Copy link
Copy Markdown
Contributor

Motivation and Context

Update public signatures / interface of ChatCompletionAgent in preparation for removing experimental tag.

Fixes: #6037
Fixes: #6523

Description

  • Include Kernel and KernelArguments in agent invocation signatures for ChatCompletionAgent
  • Change ChatCompletionAgent.ExeuctionSettings to ChatCompletionAgent.KernelArguments
  • Mirror pattern for OpenAIAssistantAgent
  • Integrate Kernel and KernelArguments.ExecutionSettings as overrides for agent invocation
  • Added new sample that explores the entire selection matrix: ChatCompletion_ServiceSelection

Contribution Checklist

@crickman Chris (crickman) added PR: in progress Under development and/or addressing feedback .NET Issue or Pull requests regarding .NET code experimental Associated with an experimental feature agents labels Aug 6, 2024
@crickman Chris (crickman) self-assigned this Aug 6, 2024
@markwallace-microsoft Mark Wallace (markwallace-microsoft) added kernel Issues or pull requests impacting the core kernel kernel.core labels Aug 6, 2024
@crickman Chris (crickman) added PR: ready for review All feedback addressed, ready for reviews and removed PR: in progress Under development and/or addressing feedback labels Aug 7, 2024
@crickman
Chris (crickman) marked this pull request as ready for review August 7, 2024 20:35
@crickman
Chris (crickman) requested a review from a team as a code owner August 7, 2024 20:35
@crickman
Chris (crickman) added this pull request to the merge queue Aug 8, 2024
@crickman Chris (crickman) removed the PR: ready for review All feedback addressed, ready for reviews label Aug 8, 2024
Merged via the queue into main with commit bdf15a8 Aug 8, 2024
@crickman
Chris (crickman) deleted the feature_agent_chat_finals branch August 8, 2024 18:29
LudoCorporateShark pushed a commit to LudoCorporateShark/semantic-kernel that referenced this pull request Aug 25, 2024
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Update public signatures / interface of `ChatCompletionAgent` in
preparation for removing experimental tag.

Fixes: microsoft#6037 
Fixes: microsoft#6523


### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

- Include `Kernel` and `KernelArguments` in agent invocation signatures
for `ChatCompletionAgent`
- Change `ChatCompletionAgent.ExeuctionSettings` to
`ChatCompletionAgent.KernelArguments`
- Mirror pattern for `OpenAIAssistantAgent`
- Integrate `Kernel` and `KernelArguments.ExecutionSettings` as
overrides for agent invocation
- Added new sample that explores the entire selection matrix:
`ChatCompletion_ServiceSelection`

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents experimental Associated with an experimental feature kernel.core kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code

Projects

Archived in project

4 participants