Skip to content

Fix setting plan arguments twice in UpdateWithPlanEntry - #72

Merged
Devis Lucato (dluc) merged 1 commit into
microsoft:mainfrom
jofri-msft:jofri/fix-plan-args
Mar 14, 2023
Merged

Devis Lucato (dluc) merged 1 commit into
microsoft:mainfrom
jofri-msft:jofri/fix-plan-args

Conversation

@jofri-msft

@jofri-msft jofri-msft commented Mar 14, 2023 •

Copy link
Copy Markdown
Contributor

Motivation and Context

Please help reviewers and future users, providing the following information:

  1. Why is this change required?
    The plan arguments are already being set a few lines above this
  2. What problem does it solve?
    Removes a duplicate and unnecessary line
  3. What scenario does it contribute to?
    Planner
  4. If it fixes an open issue, please link to the issue here.
    Didn't make an issue

Description

Remove a duplicate line in setting plan arguments in the UpdateWithPlanEntry().
The plan arguments are already set a few lines above this

Contribution Checklist

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for catching this!

@craigomatic Craig Presti (craigomatic) added the PR: ready to merge PR has been approved by all reviewers, and is ready to merge. label Mar 14, 2023
@dluc
Devis Lucato (dluc) merged commit 366ca10 into microsoft:main Mar 14, 2023
Desmond Howard (dehoward) pushed a commit to lemillermicrosoft/semantic-kernel that referenced this pull request Jun 1, 2023
Remove a duplicate line in setting plan arguments in the UpdateWithPlanEntry().
The plan arguments are already set a few lines above this
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
### Motivation and Context

<!-- Thank you for your contribution to the copilot-chat repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Fixing token usage for proposed plans + handling no token usage state
better

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
<img width="511" alt="image"
src="https://github.com/microsoft/chat-copilot/assets/125500434/d9d8c4b8-c146-4f32-951d-ac964c8a3b1b">

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: Tao Chen <[email protected]>
github-merge-queue Bot pushed a commit that referenced this pull request Dec 15, 2023
…tCollaboration) (#4314)

### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

`Example72_AgentCollaboration.RunAsPluginsAsync()` prefered to execute
as a non-terminating loop since the instruction to the art-director
emphasized finding a critique as the overall goal (as opposed to
approving copy).

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

- Tuned prompt for art-director agent and verified with multiple runs.
- Added comment to that either example has an off-chance to not reach
agreement
- Tracking further improvements:
#4313

> Note: `Example72_AgentCollaboration.RunAsPluginsAsync()` tends to be
more iterative than
`Example72_AgentCollaboration.RunCollaborationAsync()`

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Gil LaHaye <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: ready to merge PR has been approved by all reviewers, and is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants