Repository navigation
fix issue 508 - #556
Merged
Merged
fix issue 508#556
Conversation
Devis Lucato (dluc)
previously requested changes
Apr 20, 2023
Devis Lucato (dluc)
left a comment
Contributor
There was a problem hiding this comment.
a few things before merging:
- provide PR title and description, pls see PR template
- fix code style (see rider/resharper)
- make sure this follow the same naming convention and approach used for "recall"
Adrian Bonar (adrianwyatt)
requested changes
Apr 20, 2023
|
Instead of string resultString;
if (countInt == 1)
{
resultString = results.FirstOrDefault() ?? string.Empty;
}
else
{
resultString = JsonSerializer.Serialize(results);
}
return resultString;you could do something like return countInt == 1
? results.FirstOrDefault() ?? string.Empty
: JsonSerializer.Serialize(results); |
Contributor
|
LGTM - please resolve conflicts and we'll bring it in. |
Adrian Bonar (adrianwyatt)
previously approved these changes
Apr 25, 2023
Contributor
|
Merged from main, updated Google connector too, as common interface changes require it. |
Shawn Callegari (shawncal)
dismissed
Devis Lucato (dluc)’s stale review
May 6, 2023 05:02
Request for change description fulfilled.
Shawn Callegari (shawncal)
previously approved these changes
May 6, 2023
Shawn Callegari (shawncal)
approved these changes
May 6, 2023
|
Do you have new nuget package for this fix. I downloaded the code locally and trying to run it from a console app adding local references and it is giving me build code. |
|
trying to test this through a console app. As latest Nuget is not available for this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
fix issue #508
Description
WebSearch Results using the Bing Connector has a hard code value of count=1.
We need to return more than 1 result or should be able to pass count of result requested
Contribution Checklist
The code builds clean without any errors or warnings
The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
All unit tests pass, and I have added new tests where possible
I didn't break anyone 😄