Skip to content

.Net Better repeatability for Agent KernelExample #72 (Example72_AgentCollaboration) - #4314

Merged
Chris (crickman) merged 3 commits into
mainfrom
fix_agent_example72
Dec 15, 2023
Merged

Chris (crickman) merged 3 commits into
mainfrom
fix_agent_example72

Conversation

@crickman

@crickman Chris (crickman) commented Dec 15, 2023 •

Copy link
Copy Markdown
Contributor

Motivation and Context

Example72_AgentCollaboration.RunAsPluginsAsync() prefered to execute as a non-terminating loop since the instruction to the art-director emphasized finding a critique as the overall goal (as opposed to approving copy).

Description

Note: Example72_AgentCollaboration.RunAsPluginsAsync() tends to be more iterative than Example72_AgentCollaboration.RunCollaborationAsync()

Contribution Checklist

@crickman Chris (crickman) added bug Something isn't working PR: ready for review All feedback addressed, ready for reviews .NET Issue or Pull requests regarding .NET code experimental Associated with an experimental feature labels Dec 15, 2023
@crickman
Chris (crickman) requested a review from a team as a code owner December 15, 2023 19:37
@crickman Chris (crickman) linked an issue Dec 15, 2023 that may be closed by this pull request
@crickman
Chris (crickman) added this pull request to the merge queue Dec 15, 2023
Merged via the queue into main with commit 0ef7cf4 Dec 15, 2023
@crickman
Chris (crickman) deleted the fix_agent_example72 branch December 15, 2023 23:46
Bryan (Bryan-Roe) pushed a commit to Bryan-Roe-ai/semantic-kernel that referenced this pull request Oct 6, 2024
…tCollaboration) (microsoft#4314)

### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

`Example72_AgentCollaboration.RunAsPluginsAsync()` prefered to execute
as a non-terminating loop since the instruction to the art-director
emphasized finding a critique as the overall goal (as opposed to
approving copy).

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

- Tuned prompt for art-director agent and verified with multiple runs.
- Added comment to that either example has an off-chance to not reach
agreement
- Tracking further improvements:
microsoft#4313

> Note: `Example72_AgentCollaboration.RunAsPluginsAsync()` tends to be
more iterative than
`Example72_AgentCollaboration.RunCollaborationAsync()`

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Gil LaHaye <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working experimental Associated with an experimental feature .NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

.Net: Example: Example72_AssistantCollaboration

4 participants