Repository navigation
New nugets (Abstractions, Connectors.AI.OpenAI); add AAD auth, Azure ChatGPT, text+chat streaming - #420
Merged
Conversation
Devis Lucato (dluc)
force-pushed
the
dluc112azure.net20
branch
from
April 12, 2023 00:18
9849927 to
328f44f
Compare
Devis Lucato (dluc)
force-pushed
the
dluc112azure.net20
branch
2 times, most recently
from
April 12, 2023 00:51
bcbe730 to
35256fb
Compare
SergeyMenshykh
previously approved these changes
Apr 12, 2023
Shawn Callegari (shawncal)
previously approved these changes
Apr 12, 2023
Devis Lucato (dluc)
added
the
PR: in progress
Devis Lucato (dluc)
dismissed stale reviews from SergeyMenshykh and Shawn Callegari (shawncal)
via
April 14, 2023 03:34
0e61506
Devis Lucato (dluc)
force-pushed
the
dluc112azure.net20
branch
7 times, most recently
from
April 14, 2023 07:06
478d463 to
debf4ce
Compare
Devis Lucato (dluc)
added
PR: ready for review
Devis Lucato (dluc)
changed the title
Devis Lucato (dluc)
force-pushed
the
dluc112azure.net20
branch
from
April 14, 2023 07:26
debf4ce to
e8625e2
Compare
Devis Lucato (dluc)
changed the title
Contributor
Author
|
Nugets tested on a new console app. |
Devis Lucato (dluc)
force-pushed
the
dluc112azure.net20
branch
from
April 14, 2023 07:48
e8625e2 to
8b58470
Compare
SergeyMenshykh
added
PR: feedback to address
Devis Lucato (dluc)
force-pushed
the
dluc112azure.net20
branch
from
April 14, 2023 16:39
8b58470 to
80bd979
Compare
Devis Lucato (dluc)
force-pushed
the
dluc112azure.net20
branch
3 times, most recently
from
April 14, 2023 18:30
96b17e8 to
31ffc27
Compare
Devis Lucato (dluc)
added
PR: ready for review
Devis Lucato (dluc)
force-pushed
the
dluc112azure.net20
branch
from
April 14, 2023 18:43
31ffc27 to
7b0e643
Compare
Shawn Callegari (shawncal)
previously approved these changes
Apr 14, 2023
Devis Lucato (dluc)
force-pushed
the
dluc112azure.net20
branch
6 times, most recently
from
April 14, 2023 19:30
2a8c97d to
96a8fe6
Compare
Devis Lucato (dluc)
force-pushed
the
dluc112azure.net20
branch
from
April 14, 2023 19:34
96a8fe6 to
3b81583
Compare
5 tasks done
6 tasks done
Lee Miller (lemillermicrosoft)
added a commit
that referenced
this pull request
May 19, 2023
### Motivation and Context #420 skipped retry tests for OpenAI. It was noted that Azure SDK was an issue, however, I added a test for Azure OpenAI and it passes as expected as well. I know there are changes coming in the area. I'd like to re-enable the tests since they are passing to make sure functionality remains intact as design changes. ### Description Enable the previous test and clone for Azure OpenAI.
Desmond Howard (dehoward)
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
…ChatGPT, text+chat streaming (microsoft#420) ### Motivation and Context New features: * AAD auth for Azure OpenAI * Azure ChatGPT * Completion streaming * Chat streaming * log probs ### Description * Split kernel core nuget in 3 nugets and add dependency on Azure OpenAI SDK: * MS.SK.Abstractions: interfaces and common classes, ideally no business logic * MS.SK: SK runtime, depends on SK.Abstractions * MS.SK.Connectors.AI.OpenAI: OpenAI/Azure OpenAI code, depends on SK.Abstractions and Azure OpenAI SDK * Rewrote TextCompletion, ChatCompletion, EmbeddingGeneration clients to use Azure OpenAI SDK * Deleted unused code. The old OpenAI client is still in use only for DALL-E2 Note: custom retry logic doesn't work with Azure OpenAI SDK. The SDK already retries internally, using a different approach. Nugets: * Microsoft.SemanticKernel.0.12.0.nupkg * **Microsoft.SemanticKernel.Abstractions.0.12.0.nupkg** * **Microsoft.SemanticKernel.Connectors.AI.OpenAI.0.12.0.nupkg** * Microsoft.SemanticKernel.Connectors.Memory.Qdrant.0.12.0.nupkg * Microsoft.SemanticKernel.Connectors.Memory.Sqlite.0.12.0.nupkg * Microsoft.SemanticKernel.Skills.MsGraph.0.12.0.nupkg * Microsoft.SemanticKernel.Skills.Document.0.12.0.nupkg * Microsoft.SemanticKernel.Skills.OpenAPI.0.12.0.nupkg * Microsoft.SemanticKernel.Skills.Web.0.12.0.nupkg
Shawn Callegari (shawncal)
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Motivation and Context microsoft#420 skipped retry tests for OpenAI. It was noted that Azure SDK was an issue, however, I added a test for Azure OpenAI and it passes as expected as well. I know there are changes coming in the area. I'd like to re-enable the tests since they are passing to make sure functionality remains intact as design changes. ### Description Enable the previous test and clone for Azure OpenAI.
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
…ChatGPT, text+chat streaming (microsoft#420) ### Motivation and Context New features: * AAD auth for Azure OpenAI * Azure ChatGPT * Completion streaming * Chat streaming * log probs ### Description * Split kernel core nuget in 3 nugets and add dependency on Azure OpenAI SDK: * MS.SK.Abstractions: interfaces and common classes, ideally no business logic * MS.SK: SK runtime, depends on SK.Abstractions * MS.SK.Connectors.AI.OpenAI: OpenAI/Azure OpenAI code, depends on SK.Abstractions and Azure OpenAI SDK * Rewrote TextCompletion, ChatCompletion, EmbeddingGeneration clients to use Azure OpenAI SDK * Deleted unused code. The old OpenAI client is still in use only for DALL-E2 Note: custom retry logic doesn't work with Azure OpenAI SDK. The SDK already retries internally, using a different approach. Nugets: * Microsoft.SemanticKernel.0.12.0.nupkg * **Microsoft.SemanticKernel.Abstractions.0.12.0.nupkg** * **Microsoft.SemanticKernel.Connectors.AI.OpenAI.0.12.0.nupkg** * Microsoft.SemanticKernel.Connectors.Memory.Qdrant.0.12.0.nupkg * Microsoft.SemanticKernel.Connectors.Memory.Sqlite.0.12.0.nupkg * Microsoft.SemanticKernel.Skills.MsGraph.0.12.0.nupkg * Microsoft.SemanticKernel.Skills.Document.0.12.0.nupkg * Microsoft.SemanticKernel.Skills.OpenAPI.0.12.0.nupkg * Microsoft.SemanticKernel.Skills.Web.0.12.0.nupkg
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 24, 2023
### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Address code scanning alert by sanitizing the `memoryType` parameter in `ChatMemoryController` before logging. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
John (johnoliver)
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
…ChatGPT, text+chat streaming (microsoft#420) ### Motivation and Context New features: * AAD auth for Azure OpenAI * Azure ChatGPT * Completion streaming * Chat streaming * log probs ### Description * Split kernel core nuget in 3 nugets and add dependency on Azure OpenAI SDK: * MS.SK.Abstractions: interfaces and common classes, ideally no business logic * MS.SK: SK runtime, depends on SK.Abstractions * MS.SK.Connectors.AI.OpenAI: OpenAI/Azure OpenAI code, depends on SK.Abstractions and Azure OpenAI SDK * Rewrote TextCompletion, ChatCompletion, EmbeddingGeneration clients to use Azure OpenAI SDK * Deleted unused code. The old OpenAI client is still in use only for DALL-E2 Note: custom retry logic doesn't work with Azure OpenAI SDK. The SDK already retries internally, using a different approach. Nugets: * Microsoft.SemanticKernel.0.12.0.nupkg * **Microsoft.SemanticKernel.Abstractions.0.12.0.nupkg** * **Microsoft.SemanticKernel.Connectors.AI.OpenAI.0.12.0.nupkg** * Microsoft.SemanticKernel.Connectors.Memory.Qdrant.0.12.0.nupkg * Microsoft.SemanticKernel.Connectors.Memory.Sqlite.0.12.0.nupkg * Microsoft.SemanticKernel.Skills.MsGraph.0.12.0.nupkg * Microsoft.SemanticKernel.Skills.Document.0.12.0.nupkg * Microsoft.SemanticKernel.Skills.OpenAPI.0.12.0.nupkg * Microsoft.SemanticKernel.Skills.Web.0.12.0.nupkg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
New features:
Description
Note: custom retry logic doesn't work with Azure OpenAI SDK. The SDK already retries internally, using a different approach.
Nugets:
Quick overview about the nugets organization: