Repository navigation
Update READMEs, reduce code complexity, misc improvements - #374
Merged
Merged
Conversation
Devis Lucato (dluc)
added
PR: ready for review
Devis Lucato (dluc)
force-pushed
the
dluc108readme
branch
3 times, most recently
from
April 8, 2023 00:10
ad3536b to
a9440e7
Compare
Abby Harrison (awharrison-28)
suggested changes
Apr 8, 2023
Devis Lucato (dluc)
force-pushed
the
dluc108readme
branch
from
April 8, 2023 00:20
a9440e7 to
911b8df
Compare
Abby Harrison (awharrison-28)
suggested changes
Apr 8, 2023
Abby Harrison (awharrison-28)
suggested changes
Apr 8, 2023
Abby Harrison (awharrison-28)
added
PR: feedback to address
Devis Lucato (dluc)
force-pushed
the
dluc108readme
branch
3 times, most recently
from
April 8, 2023 01:29
d035a6d to
96c7f60
Compare
Devis Lucato (dluc)
force-pushed
the
dluc108readme
branch
from
April 8, 2023 01:31
96c7f60 to
b0ae8a4
Compare
Abby Harrison (awharrison-28)
approved these changes
Apr 8, 2023
Devis Lucato (dluc)
added a commit
that referenced
this pull request
Apr 12, 2023
READMEs and examples are out of date and showing incorrect code. There are also a few bugs in the SKFunction blocking simpler syntax. Extend SKFunction to allow synchronous calls and have simpler syntax when async is not required. * Update homepage README, moving all Python examples under python/README * Make SKFunction callable as per v0 * Fix bugs in SKFunction * Fix examples using realistic code * Allow to use functions synchronously
Devis Lucato (dluc)
added a commit
that referenced
this pull request
Apr 13, 2023
READMEs and examples are out of date and showing incorrect code. There are also a few bugs in the SKFunction blocking simpler syntax. Extend SKFunction to allow synchronous calls and have simpler syntax when async is not required. * Update homepage README, moving all Python examples under python/README * Make SKFunction callable as per v0 * Fix bugs in SKFunction * Fix examples using realistic code * Allow to use functions synchronously
Devis Lucato (dluc)
added a commit
that referenced
this pull request
Apr 13, 2023
READMEs and examples are out of date and showing incorrect code. There are also a few bugs in the SKFunction blocking simpler syntax. Extend SKFunction to allow synchronous calls and have simpler syntax when async is not required. * Update homepage README, moving all Python examples under python/README * Make SKFunction callable as per v0 * Fix bugs in SKFunction * Fix examples using realistic code * Allow to use functions synchronously
Desmond Howard (dehoward)
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
) READMEs and examples are out of date and showing incorrect code. There are also a few bugs in the SKFunction blocking simpler syntax. Extend SKFunction to allow synchronous calls and have simpler syntax when async is not required. * Update homepage README, moving all Python examples under python/README * Make SKFunction callable as per v0 * Fix bugs in SKFunction * Fix examples using realistic code * Allow to use functions synchronously
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
READMEs and examples are out of date and showing incorrect code. There are also a few bugs in the SKFunction blocking simpler syntax.
Extend SKFunction to allow synchronous calls and have simpler syntax when async is not required.
Description