Repository navigation
.Net: Fix postgres memory store dispose - #3177
Merged
Roger Barreto (rogerbarreto) merged 7 commits intoNov 7, 2023
Merged
Conversation
Shawn Callegari (shawncal)
added
.NET
Contributor
Author
|
Create new classlibary with <Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<LangVersion>10</LangVersion>
<Nullable>enable</Nullable>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.SemanticKernel" Version="1.0.0-beta1" />
<PackageReference Include="Microsoft.SemanticKernel.Connectors.Memory.Postgres" Version="1.0.0-beta1" />
</ItemGroup>
</Project>Copy the Reproduce the problem Reslove the problem noteIf use MyPostgresMemoryStore directly in console(.net7), that can't reproduce the problem. I can't pinpoint the exact problem, but it seems to be related to Reference npgsql/efcore.pg#2834 |
Roger Barreto (rogerbarreto)
added
the
PR: feedback to address
Roger Barreto (rogerbarreto)
approved these changes
Oct 20, 2023
Roger Barreto (rogerbarreto)
approved these changes
Oct 24, 2023
Roger Barreto (rogerbarreto)
added
PR: ready to merge
Mark Wallace (markwallace-microsoft)
approved these changes
Oct 25, 2023
Roger Barreto (rogerbarreto)
enabled auto-merge
November 1, 2023 12:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fix #3121
Description
Convert to
IDisposableto executeDispose.Contribution Checklist