Repository navigation
Python: cleanup/sync/fixes (for examples, docs, tests, notebooks) - #317
Merged
Devis Lucato (dluc) merged 12 commits intoApr 4, 2023
Merged
Devis Lucato (dluc) merged 12 commits into
Devis Lucato (dluc) merged 12 commits into
Conversation
added 9 commits
April 4, 2023 13:27
Author
|
Alex Chao (@alexchaomander) this has a lot of fixes that would make first-time use much nicer :) (things like making sure notebooks/docs are runnable and in-sync...) Also a few key bugfixes. Devis Lucato (@dluc) we should prioritize getting this in. I'll ping a few folks to get reviews |
Alex Chao (alexchaomander)
added
the
python
Alex Chao (alexchaomander)
previously approved these changes
Apr 4, 2023
Alex Chao (alexchaomander)
left a comment
Alex Chao (alexchaomander)
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Contributor
|
LGTM! tested notebooks -- all working. |
Abby Harrison (awharrison-28)
suggested changes
Apr 4, 2023
Closed
Abby Harrison (awharrison-28)
approved these changes
Apr 4, 2023
Abby Harrison (awharrison-28)
left a comment
Abby Harrison (awharrison-28)
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Devis Lucato (dluc)
pushed a commit
that referenced
this pull request
Apr 12, 2023
### Motivation and Context The `python-preview` branch is under active development and many docs/tests/examples are getting a bit out of sync. There are also a few small cleanup chores/refactors to make _usage_ easier (e.g., to make examples cleaner). I've grouped these small fixes (plus a few bug fixes) into this "cleanup" PR. ### Description This PR does the following: 1. Updates the out-of-date example in `README.md` 2. Fixes all 5 of the notebooks we support right now (1,2,3,4, and 6; notebook 5 is planner, I've blanked out most of the code there so we don't confuse people, especially as the planner API is changing) 3. Fixes a bug w/ `stop_sequences` in `(Azure)OpenAITextCompletion` 4. Fixes a bug introduced in our upgrades to the embeddings cosine-sim check (we should add more thorough tests here) 5. Cleans up tests 6. Ensures end-to-end tests are all runnable 7. Fixes up the `kernel_extensions` to work more naturally (so that end users can use them directly on the `kernel` object and get good type-hinting)
Devis Lucato (dluc)
pushed a commit
that referenced
this pull request
Apr 13, 2023
### Motivation and Context The `python-preview` branch is under active development and many docs/tests/examples are getting a bit out of sync. There are also a few small cleanup chores/refactors to make _usage_ easier (e.g., to make examples cleaner). I've grouped these small fixes (plus a few bug fixes) into this "cleanup" PR. ### Description This PR does the following: 1. Updates the out-of-date example in `README.md` 2. Fixes all 5 of the notebooks we support right now (1,2,3,4, and 6; notebook 5 is planner, I've blanked out most of the code there so we don't confuse people, especially as the planner API is changing) 3. Fixes a bug w/ `stop_sequences` in `(Azure)OpenAITextCompletion` 4. Fixes a bug introduced in our upgrades to the embeddings cosine-sim check (we should add more thorough tests here) 5. Cleans up tests 6. Ensures end-to-end tests are all runnable 7. Fixes up the `kernel_extensions` to work more naturally (so that end users can use them directly on the `kernel` object and get good type-hinting)
Devis Lucato (dluc)
pushed a commit
that referenced
this pull request
Apr 13, 2023
### Motivation and Context The `python-preview` branch is under active development and many docs/tests/examples are getting a bit out of sync. There are also a few small cleanup chores/refactors to make _usage_ easier (e.g., to make examples cleaner). I've grouped these small fixes (plus a few bug fixes) into this "cleanup" PR. ### Description This PR does the following: 1. Updates the out-of-date example in `README.md` 2. Fixes all 5 of the notebooks we support right now (1,2,3,4, and 6; notebook 5 is planner, I've blanked out most of the code there so we don't confuse people, especially as the planner API is changing) 3. Fixes a bug w/ `stop_sequences` in `(Azure)OpenAITextCompletion` 4. Fixes a bug introduced in our upgrades to the embeddings cosine-sim check (we should add more thorough tests here) 5. Cleans up tests 6. Ensures end-to-end tests are all runnable 7. Fixes up the `kernel_extensions` to work more naturally (so that end users can use them directly on the `kernel` object and get good type-hinting)
Desmond Howard (dehoward)
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
…crosoft#317) ### Motivation and Context The `python-preview` branch is under active development and many docs/tests/examples are getting a bit out of sync. There are also a few small cleanup chores/refactors to make _usage_ easier (e.g., to make examples cleaner). I've grouped these small fixes (plus a few bug fixes) into this "cleanup" PR. ### Description This PR does the following: 1. Updates the out-of-date example in `README.md` 2. Fixes all 5 of the notebooks we support right now (1,2,3,4, and 6; notebook 5 is planner, I've blanked out most of the code there so we don't confuse people, especially as the planner API is changing) 3. Fixes a bug w/ `stop_sequences` in `(Azure)OpenAITextCompletion` 4. Fixes a bug introduced in our upgrades to the embeddings cosine-sim check (we should add more thorough tests here) 5. Cleans up tests 6. Ensures end-to-end tests are all runnable 7. Fixes up the `kernel_extensions` to work more naturally (so that end users can use them directly on the `kernel` object and get good type-hinting)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The
python-previewbranch is under active development and many docs/tests/examples are getting a bit out of sync. There are also a few small cleanup chores/refactors to make usage easier (e.g., to make examples cleaner). I've grouped these small fixes (plus a few bug fixes) into this "cleanup" PR.Description
This PR does the following:
README.mdstop_sequencesin(Azure)OpenAITextCompletionkernel_extensionsto work more naturally (so that end users can use them directly on thekernelobject and get good type-hinting)Contribution Checklist
I've run
make pre-commit, I've runpytest tests/:I've also run each of the
tests/end-to-endmanually. And the code in theREADME.pyviapython3 -m asyncio(to open a REPL) and pasting it in.dotnet format