Skip to content

.Net: Use the new TensorPrimitives for numerical operations - #3113

Merged
Stephen Toub (stephentoub) merged 1 commit into
microsoft:mainfrom
stephentoub:usetensorprimitives
Oct 10, 2023
Merged

Stephen Toub (stephentoub) merged 1 commit into
microsoft:mainfrom
stephentoub:usetensorprimitives

Conversation

@stephentoub

Copy link
Copy Markdown
Member

Motivation and Context

Fixes #3021

Description

Obsoletes the numerical APIs (they should be removed when appropriate) and replaces usage with the new System.Numerics.Tensors.TensorPrimitives type.

Contribution Checklist

@stephentoub
Stephen Toub (stephentoub) requested a review from a team as a code owner October 10, 2023 16:13
@shawncal Shawn Callegari (shawncal) added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel memory connector labels Oct 10, 2023
@github-actions github-actions Bot changed the title Use the new TensorPrimitives for numerical operations .Net: Use the new TensorPrimitives for numerical operations Oct 10, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephentoub
Stephen Toub (stephentoub) added this pull request to the merge queue Oct 10, 2023
Merged via the queue into microsoft:main with commit d50361e Oct 10, 2023
@stephentoub
Stephen Toub (stephentoub) deleted the usetensorprimitives branch October 10, 2023 18:02
sangyeop-kim added a commit to sangyeop-kim/semantic-kernel that referenced this pull request Oct 11, 2023
SOE-YoungS pushed a commit to SOE-YoungS/semantic-kernel that referenced this pull request Nov 1, 2023
…t#3113)

### Motivation and Context

Fixes microsoft#3021

### Description

Obsoletes the numerical APIs (they should be removed when appropriate)
and replaces usage with the new System.Numerics.Tensors.TensorPrimitives
type.

### Contribution Checklist

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kernel Issues or pull requests impacting the core kernel memory connector .NET Issue or Pull requests regarding .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.Net: Replace vector operations with System.Numerics.Tensors

4 participants