Repository navigation
fix: add missing default value - #310
Merged
Devis Lucato (dluc) merged 2 commits intoApr 5, 2023
Merged
Devis Lucato (dluc) merged 2 commits into
Devis Lucato (dluc) merged 2 commits into
Conversation
Adrian Bonar (adrianwyatt)
added
the
python
Jordan Henkel (jjhenkel)
approved these changes
Apr 4, 2023
Jordan Henkel (jjhenkel)
left a comment
Jordan Henkel (jjhenkel)
left a comment
There was a problem hiding this comment.
This LGTM! We've made an equivalent fix (in a PR just merged recently), but adding this for safety should be fine!
Devis Lucato (dluc)
removed their request for review
April 5, 2023 21:12
Devis Lucato (dluc)
approved these changes
Apr 5, 2023
Devis Lucato (dluc)
pushed a commit
that referenced
this pull request
Apr 12, 2023
### Motivation and Context #309 ### Description missing default value in `stop_sequences`
Devis Lucato (dluc)
pushed a commit
that referenced
this pull request
Apr 13, 2023
### Motivation and Context #309 ### Description missing default value in `stop_sequences`
Devis Lucato (dluc)
pushed a commit
that referenced
this pull request
Apr 13, 2023
### Motivation and Context #309 ### Description missing default value in `stop_sequences`
Desmond Howard (dehoward)
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
### Motivation and Context microsoft#309 ### Description missing default value in `stop_sequences`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#309
Description
missing default value in
stop_sequencesContribution Checklist
dotnet format