Repository navigation
.Net: Fix for Stepwise Planner - #3088
Merged
Mark Wallace (markwallace-microsoft) merged 2 commits intoOct 6, 2023
Merged
Mark Wallace (markwallace-microsoft) merged 2 commits into
Mark Wallace (markwallace-microsoft) merged 2 commits into
Conversation
Shawn Callegari (shawncal)
added
.NET
Dmytro Struk (dmytrostruk)
added
the
PR: ready for review
Lee Miller (lemillermicrosoft)
approved these changes
Oct 5, 2023
Lee Miller (lemillermicrosoft)
left a comment
Lee Miller (lemillermicrosoft)
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks Dmytro. Perhaps similar can be done in Plan object.
Mark Wallace (markwallace-microsoft)
approved these changes
Oct 6, 2023
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Resolves: microsoft#3085 This PR contains changes to handle complex result in StepwisePlanner action by adding type converter. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> 1. Added type converter in StepwisePlanner action result processing. 2. Enabled integration test for StepwisePlanner. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 Co-authored-by: Lee Miller <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Resolves: #3085
This PR contains changes to handle complex result in StepwisePlanner action by adding type converter.
Description
Contribution Checklist