Skip to content

Python: normalize ./tests directory structure - #270

Merged
Devis Lucato (dluc) merged 2 commits into
microsoft:python-previewfrom
jjhenkel:jjhenkel/tests-cleanup
Apr 2, 2023
Merged

Devis Lucato (dluc) merged 2 commits into
microsoft:python-previewfrom
jjhenkel:jjhenkel/tests-cleanup

Conversation

@jjhenkel

Copy link
Copy Markdown

Motivation and Context

We recently merged an upgrade to the PromptTemplateEngine, let's make the rest of the tests consistent with the directory structure used in that PR.

Description

This PR does three (small) things:

  1. Makes the ./tests directory have consistent structure
  2. Re-names some of the "tests" that were at the top-level of the ./tests dir to ./tests/end-to-end (which better describes their purpose: things like basics.py and memory.py are end-to-end examples of using SK and ways to verify nothing is horribly broken)
  3. Applies isort (which we plan to add to our linting workflow here on GitHub soon)

Contribution Checklist

@alexchaomander Alex Chao (alexchaomander) added the python Pull requests for the Python Semantic Kernel label Apr 2, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dluc
Devis Lucato (dluc) merged commit 6d7812b into microsoft:python-preview Apr 2, 2023
Devis Lucato (dluc) pushed a commit that referenced this pull request Apr 12, 2023
### Motivation and Context

We recently merged an upgrade to the `PromptTemplateEngine`, let's make
the rest of the tests consistent with the directory structure used in
that PR.


### Description

This PR does three (small) things:

1. Makes the `./tests` directory have consistent structure
2. Re-names some of the "tests" that were at the top-level of the
`./tests` dir to `./tests/end-to-end` (which better describes their
purpose: things like `basics.py` and `memory.py` are end-to-end examples
of using SK and ways to verify nothing is horribly broken)
3. Applies `isort` (which we plan to add to our linting workflow here on
GitHub soon)
Devis Lucato (dluc) pushed a commit that referenced this pull request Apr 13, 2023
### Motivation and Context

We recently merged an upgrade to the `PromptTemplateEngine`, let's make
the rest of the tests consistent with the directory structure used in
that PR.


### Description

This PR does three (small) things:

1. Makes the `./tests` directory have consistent structure
2. Re-names some of the "tests" that were at the top-level of the
`./tests` dir to `./tests/end-to-end` (which better describes their
purpose: things like `basics.py` and `memory.py` are end-to-end examples
of using SK and ways to verify nothing is horribly broken)
3. Applies `isort` (which we plan to add to our linting workflow here on
GitHub soon)
Devis Lucato (dluc) pushed a commit that referenced this pull request Apr 13, 2023
### Motivation and Context

We recently merged an upgrade to the `PromptTemplateEngine`, let's make
the rest of the tests consistent with the directory structure used in
that PR.


### Description

This PR does three (small) things:

1. Makes the `./tests` directory have consistent structure
2. Re-names some of the "tests" that were at the top-level of the
`./tests` dir to `./tests/end-to-end` (which better describes their
purpose: things like `basics.py` and `memory.py` are end-to-end examples
of using SK and ways to verify nothing is horribly broken)
3. Applies `isort` (which we plan to add to our linting workflow here on
GitHub soon)
Desmond Howard (dehoward) pushed a commit to lemillermicrosoft/semantic-kernel that referenced this pull request Jun 1, 2023
### Motivation and Context

We recently merged an upgrade to the `PromptTemplateEngine`, let's make
the rest of the tests consistent with the directory structure used in
that PR.


### Description

This PR does three (small) things:

1. Makes the `./tests` directory have consistent structure
2. Re-names some of the "tests" that were at the top-level of the
`./tests` dir to `./tests/end-to-end` (which better describes their
purpose: things like `basics.py` and `memory.py` are end-to-end examples
of using SK and ways to verify nothing is horribly broken)
3. Applies `isort` (which we plan to add to our linting workflow here on
GitHub soon)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests for the Python Semantic Kernel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants