SKException consistency with docs/decisions/0004-error-handling.md#2428
Merged
dsgrieve merged 7 commits intomicrosoft:experimental-javafrom Aug 16, 2023
dsgrieve:dsgrieve/skexception-consistency
Merged
SKException consistency with docs/decisions/0004-error-handling.md#2428dsgrieve merged 7 commits intomicrosoft:experimental-javafrom dsgrieve:dsgrieve/skexception-consistency
dsgrieve merged 7 commits intomicrosoft:experimental-javafrom
dsgrieve:dsgrieve/skexception-consistency
Conversation
added 3 commits
August 14, 2023 14:11
…el into dsgrieve/skexception-consistency
milderhc
approved these changes
Aug 15, 2023
added 2 commits
August 15, 2023 13:24
johnoliver
approved these changes
Aug 16, 2023
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
…icrosoft#2428) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Where it makes sense, align Java with https://github.com/microsoft/semantic-kernel/blob/main/docs/decisions/0004-error-handling.md ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> For the most part, Java is in compliance with the decision record. This PR tries to make SKException and its inheritors consistent with each other in that each exception has a ErrorCodes enum and an ErrorCodes member with a getter, that the enums use upper case with underscore, and that the formatting of the error message is consistent. This also tries to address "Unnecessary and verbose exceptions", but there was not much to be gained there. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
…icrosoft#2428) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Where it makes sense, align Java with https://github.com/microsoft/semantic-kernel/blob/main/docs/decisions/0004-error-handling.md ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> For the most part, Java is in compliance with the decision record. This PR tries to make SKException and its inheritors consistent with each other in that each exception has a ErrorCodes enum and an ErrorCodes member with a getter, that the enums use upper case with underscore, and that the formatting of the error message is consistent. This also tries to address "Unnecessary and verbose exceptions", but there was not much to be gained there. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Where it makes sense, align Java with https://github.com/microsoft/semantic-kernel/blob/main/docs/decisions/0004-error-handling.md
Description
For the most part, Java is in compliance with the decision record. This PR tries to make SKException and its inheritors consistent with each other in that each exception has a ErrorCodes enum and an ErrorCodes member with a getter, that the enums use upper case with underscore, and that the formatting of the error message is consistent. This also tries to address "Unnecessary and verbose exceptions", but there was not much to be gained there.
Contribution Checklist