Python: Implement Function calling for Chat by eavanvalkenburg · Pull Request #2356 · microsoft/semantic-kernel

Eduard van Valkenburg (eavanvalkenburg) · 2023-08-08T13:35:56Z

Motivation and Context

I built support for function calling into SK!

Related to/fixes:

Description

This implementation builds on top of all the existing pieces, but did require some major work, so feel free to comment on where that is or is not appropriate.

Added a ChatMessage class to capture the relevant pieces of function calling (name and content)
Added a complete_chat_with_functions_async into OpenAIChatCompletions class
Added a function_call field to ChatRequestSettings class
Added several helper functions and smaller changes
Added a sample with updated core_skill that uses function calling to demonstrate
Added a second sample that shows how to use function_calling with non-sk functions.

Contribution Checklist

The code builds clean without any errors or warnings
The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
All unit tests pass, and I have added new tests where possible
I didn't break anyone 😄

Lee Miller (lemillermicrosoft) · 2023-08-25T17:41:26Z

Handful of checks are not yet passing, so will turn this one to draft for now. Please feel free to re-open when things are resolved.

Eduard van Valkenburg (eavanvalkenburg) · 2023-08-26T11:29:21Z

Gina Triolo (@gitri-ms) I got a hanging push earlier, naming is now updated.
Abby Harrison (@awharrison-28) added in the implementation of the chat_messages incl tests from #2442

Eduard van Valkenburg (eavanvalkenburg) · 2023-08-26T12:22:41Z

Lee Miller (@lemillermicrosoft) fixed all tests

Gina Triolo (gitri-ms)

Just one tiny thing to fix, then LGTM!

Lee Miller (lemillermicrosoft)

Left some comments, I think we should remove changes to the template config where they are not required and lean on the skill collection for supplying available functions.

Lee Miller (lemillermicrosoft) · 2023-08-30T18:39:55Z

Also, right now, having trouble getting it to work.

### Motivation and Context  I built support for function calling into SK! Related to/fixes: - microsoft#2315 - microsoft#2175 - microsoft#1450 ### Description  This implementation builds on top of all the existing pieces, but did require some major work, so feel free to comment on where that is or is not appropriate. - Added a `ChatMessage` class to capture the relevant pieces of function calling (name and content) - Added a `complete_chat_with_functions_async` into OpenAIChatCompletions class - Added a `function_call` field to ChatRequestSettings class - Added several helper functions and smaller changes - Added a sample with updated core_skill that uses function calling to demonstrate - Added a second sample that shows how to use function_calling with non-sk functions. ### Contribution Checklist  - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Abby Harrison <[email protected]>

Eduard van Valkenburg (eavanvalkenburg) requested a review from a team as a code owner August 8, 2023 13:35

Shawn Callegari (shawncal) added the python Pull requests for the Python Semantic Kernel label Aug 8, 2023

Eduard van Valkenburg (eavanvalkenburg) mentioned this pull request Aug 8, 2023

OpenAI Chat Service classes should support function calling and other API updates #1450

Closed

Abby Harrison (awharrison-28) reviewed Aug 8, 2023

View reviewed changes

Comment thread python/samples/kernel-syntax-examples/chat_gpt_api_function_calling.py Resolved

Abby Harrison (awharrison-28) self-assigned this Aug 9, 2023

Abby Harrison (awharrison-28) linked an issue Aug 9, 2023 that may be closed by this pull request

OpenAI Chat Service classes should support function calling and other API updates #1450

Closed

Abby Harrison (awharrison-28) suggested changes Aug 9, 2023

View reviewed changes

Eduard van Valkenburg (eavanvalkenburg) requested a review from a team as a code owner August 21, 2023 14:29

Shawn Callegari (shawncal) added the samples label Aug 21, 2023

Abby Harrison (awharrison-28) reviewed Aug 21, 2023

View reviewed changes

Comment thread python/semantic_kernel/skill_definition/sk_function_decorator.py Resolved

Gina Triolo (gitri-ms) self-assigned this Aug 23, 2023

Eduard van Valkenburg (eavanvalkenburg) force-pushed the function_calling branch 2 times, most recently from b8246de to 5cd7f85 Compare August 25, 2023 06:56

Lee Miller (lemillermicrosoft) marked this pull request as draft August 25, 2023 17:41

Gina Triolo (gitri-ms) reviewed Aug 25, 2023

View reviewed changes

Comment thread python/semantic_kernel/core_skills/math_skill.py Resolved

Comment thread python/semantic_kernel/connectors/ai/open_ai/services/open_ai_chat_completion.py Resolved

Comment thread python/semantic_kernel/skill_definition/sk_function_decorator.py Resolved

Eduard van Valkenburg (eavanvalkenburg) force-pushed the function_calling branch 2 times, most recently from 40b8ec0 to 10c93fa Compare August 26, 2023 11:25

Eduard van Valkenburg (eavanvalkenburg) marked this pull request as ready for review August 27, 2023 17:52

Abby Harrison (awharrison-28) reviewed Aug 29, 2023

View reviewed changes

Comment thread samples/skills/FunSkill/Joke/config.json Resolved

Abby Harrison (awharrison-28) approved these changes Aug 29, 2023

View reviewed changes

Gina Triolo (gitri-ms) approved these changes Aug 29, 2023

View reviewed changes

Comment thread samples/skills/FunSkill/Joke/config.json Resolved

Eduard van Valkenburg (eavanvalkenburg) changed the title ~~Python: WIP: Implement Function calling for Chat~~ Python: Implement Function calling for Chat Aug 30, 2023

Lee Miller (lemillermicrosoft) previously requested changes Aug 30, 2023

View reviewed changes

Lee Miller (lemillermicrosoft) reviewed Aug 30, 2023

View reviewed changes

Comment thread python/samples/kernel-syntax-examples/chat_gpt_api_function_calling.py Resolved

Gina Triolo (gitri-ms) marked this pull request as draft August 30, 2023 20:22

Gina Triolo (gitri-ms) self-requested a review August 30, 2023 20:22

Eduard van Valkenburg (eavanvalkenburg) added 12 commits October 4, 2023 21:37

wip updates

91aa765

first implementation of filtering

8f02b0e

added full_name

25ae882

small fixes

63c6e10

refactored to be kwargs driven

10e29ce

fixed handling chat_system_prompt

d1fc727

black and cleanup of sample

98b588f

cleanup

ac75278

moved things to utils and added sample

1cde2f2

bit of cleanup

ed64e1e

added function_call field to context

b621e04

made functioncall reference type checking only in context

5adac35

Eduard van Valkenburg (eavanvalkenburg) force-pushed the function_calling branch from 69e47a8 to 5adac35 Compare October 4, 2023 19:38

fix FunctionCall import in skcontext

4070e9e

Eduard van Valkenburg (eavanvalkenburg) requested review from Gina Triolo (gitri-ms) and Lee Miller (lemillermicrosoft) October 4, 2023 19:56

Gina Triolo (gitri-ms) added PR: ready for review All feedback addressed, ready for reviews and removed PR: paused PR temporarily parked labels Oct 5, 2023

Gina Triolo (gitri-ms) reviewed Oct 5, 2023

View reviewed changes

Comment thread python/semantic_kernel/orchestration/sk_context.py Resolved

Comment thread python/semantic_kernel/semantic_functions/chat_prompt_template.py Resolved

Eduard van Valkenburg (eavanvalkenburg) and others added 5 commits October 9, 2023 09:28

moved function_call to generic object store in context

e7a310e

Merge branch 'main' into function_calling

8ccda8c

further refinement

7892f5a

Merge branch 'main' into function_calling

5a25f2d

Merge branch 'main' into function_calling

f52ee26

Gina Triolo (gitri-ms) approved these changes Oct 12, 2023

View reviewed changes

Gina Triolo (gitri-ms) added this pull request to the merge queue Oct 12, 2023

Merged via the queue into microsoft:main with commit 85ee34b Oct 12, 2023

Eduard van Valkenburg (eavanvalkenburg) deleted the function_calling branch October 12, 2023 18:46

Conversation

Eduard van Valkenburg (eavanvalkenburg) commented Aug 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation and Context

Description

Contribution Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lee Miller (lemillermicrosoft) commented Aug 25, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Eduard van Valkenburg (eavanvalkenburg) commented Aug 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Eduard van Valkenburg (eavanvalkenburg) commented Aug 26, 2023

Uh oh!

Uh oh!

Gina Triolo (gitri-ms) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Lee Miller (lemillermicrosoft) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lee Miller (lemillermicrosoft) commented Aug 30, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Eduard van Valkenburg (eavanvalkenburg) commented Aug 8, 2023 •

edited

Loading

Eduard van Valkenburg (eavanvalkenburg) commented Aug 26, 2023 •

edited

Loading