Skip to content

python: Porting TimeSkill - #209

Merged
Devis Lucato (dluc) merged 6 commits into
microsoft:python-previewfrom
JTremb:feature/TimeSkill
Mar 29, 2023
Merged

Devis Lucato (dluc) merged 6 commits into
microsoft:python-previewfrom
JTremb:feature/TimeSkill

Conversation

@JTremb

Copy link
Copy Markdown
Contributor

Motivation and Context

Port of the core TimeSkill

Description

This PR adds the core TimeSkill with unit tests.

kernel = sk.create_kernel()
kernel.import_skill(TimeSkill(), "time")
sk_prompt = """
{{time.now}}
"""

Contribution Checklist

@alexchaomander Alex Chao (alexchaomander) added the python Pull requests for the Python Semantic Kernel label Mar 29, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for adding this!

@jjhenkel Jordan Henkel (jjhenkel) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto, LGTM! Thank you Jerome Tremblay (@JTremb)!!

@awharrison-28 Abby Harrison (awharrison-28) added the PR: ready to merge PR has been approved by all reviewers, and is ready to merge. label Mar 29, 2023
@dluc
Devis Lucato (dluc) merged commit dbbb082 into microsoft:python-preview Mar 29, 2023
@JTremb
Jerome Tremblay (JTremb) deleted the feature/TimeSkill branch March 29, 2023 23:49
Devis Lucato (dluc) pushed a commit that referenced this pull request Apr 12, 2023
### Motivation and Context
Port of the core TimeSkill

### Description
This PR adds the core TimeSkill with unit tests.

```
kernel = sk.create_kernel()
kernel.import_skill(TimeSkill(), "time")
```

```
sk_prompt = """
{{time.now}}
"""
```
Devis Lucato (dluc) pushed a commit that referenced this pull request Apr 13, 2023
### Motivation and Context
Port of the core TimeSkill

### Description
This PR adds the core TimeSkill with unit tests.

```
kernel = sk.create_kernel()
kernel.import_skill(TimeSkill(), "time")
```

```
sk_prompt = """
{{time.now}}
"""
```
Devis Lucato (dluc) pushed a commit that referenced this pull request Apr 13, 2023
### Motivation and Context
Port of the core TimeSkill

### Description
This PR adds the core TimeSkill with unit tests.

```
kernel = sk.create_kernel()
kernel.import_skill(TimeSkill(), "time")
```

```
sk_prompt = """
{{time.now}}
"""
```
Desmond Howard (dehoward) pushed a commit to lemillermicrosoft/semantic-kernel that referenced this pull request Jun 1, 2023
### Motivation and Context
Port of the core TimeSkill

### Description
This PR adds the core TimeSkill with unit tests.

```
kernel = sk.create_kernel()
kernel.import_skill(TimeSkill(), "time")
```

```
sk_prompt = """
{{time.now}}
"""
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: ready to merge PR has been approved by all reviewers, and is ready to merge. python Pull requests for the Python Semantic Kernel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants