Repository navigation
Python: Upgrade PromptTemplateEngine (bring back to parity w/ C# version) - #200
Merged
Devis Lucato (dluc) merged 37 commits intoApr 1, 2023
Merged
Conversation
Needed continue, not break. Add option to grab deployment name from .env
With a bit of refactoring, we can avoid duplicating too much code here; to add an Azure* model variant, we just subclass the OpenAI* version
This is an attempt to add support for ChatGPT APIs in Python; Trying to keep changes as minimal as possible here
Need to tie these new models into the rest of the kernel
(and one more utility func)
Author
|
|
Devis Lucato (dluc)
self-requested a review
March 29, 2023 01:59
Devis Lucato (dluc)
requested changes
Mar 29, 2023
Devis Lucato (dluc)
left a comment
Devis Lucato (dluc)
left a comment
Contributor
There was a problem hiding this comment.
Awesome work, I'll spend some time checking for parity and correctness, first glance looks good. I hope all those tests were useful with porting the parsing logic.
Devis Lucato (dluc)
added
the
python
Devis Lucato (dluc)
approved these changes
Apr 1, 2023
Devis Lucato (dluc)
pushed a commit
that referenced
this pull request
Apr 12, 2023
…rsion) (#200) ### Motivation and Context The C# Semantic Kernel has recently undergone an upgrade to its `PromptTemplateEngine`. This brings Python back in line with the semantics of Prompt Templates in C#. ### Description Here, unlike the original port, I've tried to make things more pythonic/idiomatic (instead of trying to directly mirror the C# codebase). I've also brought over the corresponding unit tests (and added some of my own as I was building/validating).
Devis Lucato (dluc)
pushed a commit
that referenced
this pull request
Apr 13, 2023
…rsion) (#200) ### Motivation and Context The C# Semantic Kernel has recently undergone an upgrade to its `PromptTemplateEngine`. This brings Python back in line with the semantics of Prompt Templates in C#. ### Description Here, unlike the original port, I've tried to make things more pythonic/idiomatic (instead of trying to directly mirror the C# codebase). I've also brought over the corresponding unit tests (and added some of my own as I was building/validating).
Devis Lucato (dluc)
pushed a commit
that referenced
this pull request
Apr 13, 2023
…rsion) (#200) ### Motivation and Context The C# Semantic Kernel has recently undergone an upgrade to its `PromptTemplateEngine`. This brings Python back in line with the semantics of Prompt Templates in C#. ### Description Here, unlike the original port, I've tried to make things more pythonic/idiomatic (instead of trying to directly mirror the C# codebase). I've also brought over the corresponding unit tests (and added some of my own as I was building/validating).
Desmond Howard (dehoward)
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
…rsion) (microsoft#200) ### Motivation and Context The C# Semantic Kernel has recently undergone an upgrade to its `PromptTemplateEngine`. This brings Python back in line with the semantics of Prompt Templates in C#. ### Description Here, unlike the original port, I've tried to make things more pythonic/idiomatic (instead of trying to directly mirror the C# codebase). I've also brought over the corresponding unit tests (and added some of my own as I was building/validating).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The C# Semantic Kernel has recently undergone an upgrade to its
PromptTemplateEngine. This brings Python back in line with the semantics of Prompt Templates in C#.Description
Here, unlike the original port, I've tried to make things more pythonic/idiomatic (instead of trying to directly mirror the C# codebase). I've also brought over the corresponding unit tests (and added some of my own as I was building/validating).
Contribution Checklist
dotnet format