Repository navigation
.Net: Improve Milvus filtering - #14498
Merged
westey (westey-m) merged 5 commits intoSep 30, 2026
Merged
Conversation
westey (westey-m)
had a problem deploying
to
github-app-auth
September 28, 2026 17:02 — with 
GitHub Actions
Failure
GitHub Actions
Failure
westey (westey-m)
had a problem deploying
to
github-app-auth
September 28, 2026 17:02 — with
GitHub Actions
Failure
GitHub Actions
Failure
westey (westey-m)
had a problem deploying
to
integration
September 28, 2026 17:02 — with
GitHub Actions
Failure
GitHub Actions
Failure
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Moderate issues remain with skipped integration tests, an index-build race, and missing PR CI coverage.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Improves Milvus record-ID filtering by escaping literal IDs and requiring compatible server versions.
Changes:
- Adds safe ID filter construction and version validation.
- Updates Milvus documentation.
- Adds unit tests, integration fixtures, and legacy-server coverage.
| File | Summary |
|---|---|
dotnet/test/VectorData/Milvus.UnitTests/MilvusMemoryStoreTests.cs |
Adds escaped-ID integration scenarios; tests are skipped and index creation may race searches. |
dotnet/test/VectorData/Milvus.UnitTests/MilvusLegacyServerTests.cs |
Adds legacy-server compatibility coverage, but the test is skipped. |
dotnet/test/VectorData/Milvus.UnitTests/MilvusFixture.cs |
Configures Milvus and MinIO test containers. |
dotnet/test/VectorData/Milvus.UnitTests/MilvusFilterTests.cs |
Tests filter encoding and version validation. |
dotnet/test/VectorData/Milvus.UnitTests/Milvus.UnitTests.csproj |
Defines the Milvus test project. |
dotnet/src/VectorData/Milvus/README.md |
Documents server and ID requirements. |
dotnet/src/VectorData/Milvus/MilvusMemoryStore.cs |
Adds version checks and safe ID filtering. |
dotnet/src/VectorData/Milvus/Milvus.csproj |
Exposes internals to tests. |
dotnet/MEVD.slnx |
Registers the new test project, which is not covered by PR CI. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
westey (westey-m)
had a problem deploying
to
github-app-auth
September 28, 2026 17:48 — with
GitHub Actions
Failure
GitHub Actions
Failure
westey (westey-m)
temporarily deployed
to
integration
September 28, 2026 17:49 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
westey (westey-m)
enabled auto-merge
September 28, 2026 18:00
westey (westey-m)
had a problem deploying
to
github-app-auth
September 28, 2026 18:01 — with
GitHub Actions
Failure
GitHub Actions
Failure
westey (westey-m)
temporarily deployed
to
integration
September 28, 2026 18:02 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
westey (westey-m)
temporarily deployed
to
github-app-auth
September 29, 2026 14:49 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
westey (westey-m)
temporarily deployed
to
integration
September 29, 2026 14:49 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
semantic-kernel-automation
Bot
added
.NET
github-actions
Bot
changed the title
SergeyMenshykh
approved these changes
Sep 30, 2026
Roger Barreto (rogerbarreto)
approved these changes
Sep 30, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 30, 2026
westey (westey-m)
temporarily deployed
to
github-app-auth
September 30, 2026 17:54 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
westey (westey-m)
enabled auto-merge
September 30, 2026 17:54
westey (westey-m)
temporarily deployed
to
integration
September 30, 2026 17:54 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
Improve Milvus filtering to allow more id types to be supported
Contribution Checklist