Repository navigation
Update CommunityToolkit VectorData package names - #14333
Conversation
Co-authored-by: adamsitnik <[email protected]>
Co-authored-by: adamsitnik <[email protected]>
There was a problem hiding this comment.
Pull request overview
Updates Semantic Kernel’s .NET VectorData references to match CommunityToolkit/AI’s renamed Azure Cosmos providers (Cosmos MongoDB → AzureDocumentDB, Cosmos NoSQL → AzureCosmosDB), ensuring package references and sample DI registrations align with the new names.
Changes:
- Updated VectorData README links to the new CommunityToolkit/AI source directories (AzureDocumentDB / AzureCosmosDB).
- Updated central package versions and sample
.csprojpackage references to the renamed NuGet packages. - Updated sample DI extension method call sites to the renamed registration APIs (
AddDocumentDB...,AddCosmos...).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| dotnet/src/VectorData/CosmosNoSql/README.md | Updates CommunityToolkit/AI repo link to the new AzureCosmosDB source path. |
| dotnet/src/VectorData/CosmosMongoDB/README.md | Updates CommunityToolkit/AI repo link to the new AzureDocumentDB source path. |
| dotnet/samples/Demos/VectorStoreRAG/VectorStoreRAG.csproj | Switches sample package references to AzureDocumentDB/AzureCosmosDB. |
| dotnet/samples/Demos/VectorStoreRAG/Program.cs | Updates DI registration calls to renamed provider extension methods. |
| dotnet/samples/Concepts/Concepts.csproj | Updates sample package reference to AzureDocumentDB and adjusts related comment text. |
| dotnet/samples/Concepts/Caching/SemanticCachingWithFilters.cs | Updates vector store registration API call to AddDocumentDBVectorStore. |
| dotnet/Directory.Packages.props | Renames centrally-managed VectorData package IDs to AzureDocumentDB/AzureCosmosDB. |
Suppressed comments (1)
dotnet/samples/Demos/VectorStoreRAG/Program.cs:89
- The switch case label still uses "CosmosNoSql" while the registration API is now AddCosmosCollection from the AzureCosmosDB provider. Add a brief inline note so readers can connect the old config name with the renamed provider/package.
case "CosmosNoSql":
kernelBuilder.Services.AddCosmosCollection<string, TextSnippet<string>>(
appConfig.RagConfig.CollectionName,
appConfig.CosmosNoSqlConfig.ConnectionString,
appConfig.CosmosNoSqlConfig.DatabaseName);
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: No findings
Scope: full PR (2 commit(s)): 503c4295fa9a, 50b32a8b3ade
Model: claude-opus-4.8
Overview
This PR is a purely mechanical rename tracking an upstream CommunityToolkit/AI package rename: CommunityToolkit.VectorData.CosmosMongoDB -> .AzureDocumentDB and .CosmosNoSql -> .AzureCosmosDB, with the corresponding extension-method call sites (AddCosmosMongo* -> AddDocumentDB*, AddCosmosNoSql* -> AddCosmos*) and two README stub links updated. The change is complete and internally consistent: central package versions are defined once each with matching versions, every consuming PackageReference resolves, no stale package IDs or old call sites remain anywhere in the repo, and the new method names/signatures were confirmed against the actually published packages. No shipped SK library surface, serialization, persistence, or trust boundary is affected. Residual risk is limited to cosmetic tombstone-name drift in the two connector stub READMEs, which has no consumer or contract impact.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
Adam Sitnik (adamsitnik)
left a comment
Adam Sitnik (adamsitnik)
left a comment
There was a problem hiding this comment.
Copilot address my feedback
Co-authored-by: adamsitnik <[email protected]>
Adam Sitnik (adamsitnik)
left a comment
Adam Sitnik (adamsitnik)
left a comment
There was a problem hiding this comment.
We are almost there
Co-authored-by: Adam Sitnik <[email protected]>
GitHub Actions
Error
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
dotnet/samples/Concepts/Concepts.csproj:12
- The comment attributes AzureCosmosDisableNewtonsoftJsonCheck specifically to CommunityToolkit.VectorData.AzureCosmosDB, but this project doesn’t reference that package directly. This makes the comment easy to misread if the need for the property is due to a transitive Microsoft.Azure.Cosmos dependency (or is simply kept as a precaution). Consider making the comment describe the Microsoft.Azure.Cosmos Newtonsoft.Json check without tying it to a specific provider package.
<!-- CommunityToolkit.VectorData.AzureCosmosDB pulls Microsoft.Azure.Cosmos which added a mandatory Newtonsoft.Json explicit-reference check; disable it since we don't use Newtonsoft.Json directly -->
Co-authored-by: adamsitnik <[email protected]>
Motivation and Context
CommunityToolkit/AI renamed the Cosmos MongoDB and Cosmos NoSQL VectorData providers. Semantic Kernel references should point to the renamed packages and source locations.
Description
README links
MEVD/src/AzureDocumentDBMEVD/src/AzureCosmosDBCentral package versions
CommunityToolkit.VectorData.CosmosMongoDB→CommunityToolkit.VectorData.AzureDocumentDBCommunityToolkit.VectorData.CosmosNoSql→CommunityToolkit.VectorData.AzureCosmosDBSample references
AddCosmosMongo...→AddDocumentDB...AddCosmosNoSql...→AddCosmos...Contribution Checklist