Skip to content

Java: Complete porting TextSkill - #1275

Merged
Mark Wallace (markwallace-microsoft) merged 8 commits into
microsoft:experimental-javafrom
johnoliver:textSkill
Jun 8, 2023
Merged

Mark Wallace (markwallace-microsoft) merged 8 commits into
microsoft:experimental-javafrom
johnoliver:textSkill

Conversation

@johnoliver

Copy link
Copy Markdown
Member

Additionally removes the defaulting of the name for an annotated native input parameter and requires explicit naming of the input name

@shawncal Shawn Callegari (shawncal) changed the title Complete porting TextSkill Java: Complete porting TextSkill May 30, 2023
@shawncal Shawn Callegari (shawncal) added PR: ready for review All feedback addressed, ready for reviews java Issue or PR regarding Java code labels May 30, 2023
@johnoliver
John (johnoliver) dismissed a stale review via 61f203d May 31, 2023 13:49
Luigi Montoya (Luigi96) and others added 4 commits June 2, 2023 08:24
### Motivation and Context

### Description
Opening a PR with initial CI changes to build and run tests against Java
packages.

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [ ] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

---------

Co-authored-by: joe-braley <[email protected]>
Co-authored-by: Luigi96 <[email protected]>
Co-authored-by: Mark Wallace <[email protected]>
…1199)

### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->


### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->


### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [ ] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

Co-authored-by: Mark Wallace <[email protected]>
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Complete the implementation of VolatileMemoryStoreTests


### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
Complete the implementation of VolatileMemoryStoreTests. Make
implementation consistent with tests.

Please note that I added equals and hashCode methods to Embedding,
MemoryRecord, and MemoryRecordMetadata because these unit tests use
assertEquals. Alternatively, I could have created methods in
VolatileMemoryStoreTests to check equality. I'm good with either way.

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [x] The code builds clean without any errors or warnings
- [x] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [x] ~The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`~ Java code follows AOSP style
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Mark Wallace <[email protected]>
### Motivation and Context

### Description
Add command to PRs to properly format Java code.

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [ ] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

---------

Co-authored-by: Mark Wallace <[email protected]>
@markwallace-microsoft Mark Wallace (markwallace-microsoft) added the PR: ready to merge PR has been approved by all reviewers, and is ready to merge. label Jun 2, 2023
@markwallace-microsoft
Mark Wallace (markwallace-microsoft) merged commit 1e9f838 into microsoft:experimental-java Jun 8, 2023
John (johnoliver) added a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
Additionally removes the defaulting of the name for an annotated native
input parameter and requires explicit naming of the input name

---------

Co-authored-by: Luigi Montoya <[email protected]>
Co-authored-by: joe-braley <[email protected]>
Co-authored-by: Luigi96 <[email protected]>
Co-authored-by: Mark Wallace <[email protected]>
Co-authored-by: David Grieve <[email protected]>
John (johnoliver) added a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
Additionally removes the defaulting of the name for an annotated native
input parameter and requires explicit naming of the input name

---------

Co-authored-by: Luigi Montoya <[email protected]>
Co-authored-by: joe-braley <[email protected]>
Co-authored-by: Luigi96 <[email protected]>
Co-authored-by: Mark Wallace <[email protected]>
Co-authored-by: David Grieve <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Issue or PR regarding Java code PR: ready for review All feedback addressed, ready for reviews PR: ready to merge PR has been approved by all reviewers, and is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants