Repository navigation
Add Lint Workflow - #123
Devis Lucato (dluc) merged 13 commits into
Conversation
Aditya Gudimella (AdityaGudimella)
changed the title
Lee Miller (lemillermicrosoft)
added
the
python
|
This would be awesome to have! Looks great! (Alex Chao (@alexchaomander) and Devis Lucato (@dluc) how do we want to do reviews on the Python side of things? Are there designated folks from the main SK team that are going to sign off, or are those of us working on SK Python going to be the ones to approve? Could do both? Thoughts?) |
|
Jordan Henkel (@jjhenkel) I'm all for merging this, could you test and approve?
no one designated, but having your approvals would be a great plus at least as a sign that everything is in order. While we're in preview we can move fast. We love small PRs, please help with that :-) I'll help with design and sync across languages. |
Devis Lucato (dluc)
added
the
PR: ready for review
|
Aditya Gudimella (@AdityaGudimella) I was able to run this locally via |
|
Jordan Henkel (@jjhenkel) There are a couple of ways to do what you want. Please tell me which one you prefer.
I personally prefer Option 2 because it keeps things consistent between the workflows and local development. Also what is |
|
Aditya Gudimella (@AdityaGudimella) when I refer to testing here I just mean testing the workflow yml you wrote (not tests for the code). I was using this tool: https://github.com/nektos/act to verify things locally (and, to get things to run, I needed to make those small changes) |
|
This is super cool and super useful! Let me add support to this right away! |
### Motivation and Context This PR adds a Lint Github workflow so that code style rules can be enforced for PRs. 1. This forms a baseline workflow that can be used as a template for future workflows that will be added. 2. It helps enforce code style rules. Currently it only checks PyCodeStyle and PyFlakes. Others will be added in the future. 3. Contributes to automated testing 4. Does not fix any open issue. ### Description Added Ruff as a dev dependency. Added Github workflow which runs Ruff. --------- Co-authored-by: Aditya Gudimella <[email protected]> Co-authored-by: Devis Lucato <[email protected]>
### Motivation and Context This PR adds a Lint Github workflow so that code style rules can be enforced for PRs. 1. This forms a baseline workflow that can be used as a template for future workflows that will be added. 2. It helps enforce code style rules. Currently it only checks PyCodeStyle and PyFlakes. Others will be added in the future. 3. Contributes to automated testing 4. Does not fix any open issue. ### Description Added Ruff as a dev dependency. Added Github workflow which runs Ruff. --------- Co-authored-by: Aditya Gudimella <[email protected]> Co-authored-by: Devis Lucato <[email protected]>
### Motivation and Context This PR adds a Lint Github workflow so that code style rules can be enforced for PRs. 1. This forms a baseline workflow that can be used as a template for future workflows that will be added. 2. It helps enforce code style rules. Currently it only checks PyCodeStyle and PyFlakes. Others will be added in the future. 3. Contributes to automated testing 4. Does not fix any open issue. ### Description Added Ruff as a dev dependency. Added Github workflow which runs Ruff. --------- Co-authored-by: Aditya Gudimella <[email protected]> Co-authored-by: Devis Lucato <[email protected]>
### Motivation and Context This PR adds a Lint Github workflow so that code style rules can be enforced for PRs. 1. This forms a baseline workflow that can be used as a template for future workflows that will be added. 2. It helps enforce code style rules. Currently it only checks PyCodeStyle and PyFlakes. Others will be added in the future. 3. Contributes to automated testing 4. Does not fix any open issue. ### Description Added Ruff as a dev dependency. Added Github workflow which runs Ruff. --------- Co-authored-by: Aditya Gudimella <[email protected]> Co-authored-by: Devis Lucato <[email protected]>
### Motivation and Context This PR adds a Lint Github workflow so that code style rules can be enforced for PRs. 1. This forms a baseline workflow that can be used as a template for future workflows that will be added. 2. It helps enforce code style rules. Currently it only checks PyCodeStyle and PyFlakes. Others will be added in the future. 3. Contributes to automated testing 4. Does not fix any open issue. ### Description Added Ruff as a dev dependency. Added Github workflow which runs Ruff. --------- Co-authored-by: Aditya Gudimella <[email protected]> Co-authored-by: Devis Lucato <[email protected]>
Mike Kang (pixelbits-mk)
left a comment
Mike Kang (pixelbits-mk)
left a comment
There was a problem hiding this comment.
✅ APPROVED - AI Code Review
📋 Summary
Simple change detected - This PR is a straightforward addition of linting configuration and CI workflow. The changes are infrastructure/tooling focused: adding Ruff linter as a dev dependency, configuring a GitHub Actions workflow for linting, and making a minor formatting fix. No architectural, security, performance, or complex development patterns are involved. The changes are well-structured and follow good DevOps practices. Inspirational review included to acknowledge the valuable contribution toward code quality automation.
🌟 Your thoughtful implementation of parallel lint jobs for both Ruff and Black shows excellent attention to CI/CD scalability, setting up a robust foundation that will help the entire team maintain high code quality standards.
🤖 Generated by AI Code Review Agent
Mike Kang (pixelbits-mk)
left a comment
Mike Kang (pixelbits-mk)
left a comment
There was a problem hiding this comment.
✅ APPROVED - AI Code Review
📋 Summary
Simple change detected - This PR is a straightforward addition of linting configuration and CI workflow. The changes are purely infrastructure/tooling focused, adding Ruff linter and Black formatter checks via GitHub Actions. There's one minor code style fix (removing blank line) but no functional changes. No specialized reviews needed as this doesn't impact architecture, security, performance or complex development patterns. However, always good to acknowledge the developer's initiative in improving code quality through automated checks!
🌟 Your thoughtful implementation of separate 'ruff' and 'black' jobs in the workflow shows excellent attention to separation of concerns, making the linting process both modular and maintainable for future contributors.
🤖 Generated by AI Code Review Agent
Motivation and Context
This PR adds a Lint Github workflow so that code style rules can be enforced for PRs.
Description
Added Ruff as a dev dependency. Added Github workflow which runs Ruff.
Contribution Checklist