Repository navigation
.Net: Remove SqlDataReaderDictionary in SQL Server provider - #12241
Merged
Merged
Conversation
Mark Wallace (markwallace-microsoft)
added
.NET
Shay Rojansky (roji)
temporarily deployed
to
integration
May 22, 2025 16:40 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
github-actions
Bot
changed the title
Shay Rojansky (roji)
force-pushed
the
SimplifySqlServer
branch
from
May 22, 2025 16:54
a7517a5 to
57f9c48
Compare
Shay Rojansky (roji)
temporarily deployed
to
integration
May 22, 2025 16:54 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Shay Rojansky (roji)
enabled auto-merge
May 22, 2025 17:12
Adam Sitnik (adamsitnik)
approved these changes
May 23, 2025
Adam Sitnik (adamsitnik)
left a comment
Adam Sitnik (adamsitnik)
left a comment
Member
There was a problem hiding this comment.
Very nice! Thank you Shay Rojansky (@roji) 👍
westey (westey-m)
approved these changes
May 23, 2025
Shay Rojansky (roji)
temporarily deployed
to
integration
May 23, 2025 13:45 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
westey (westey-m)
approved these changes
May 23, 2025
Shay Rojansky (roji)
had a problem deploying
to
integration
May 23, 2025 15:30 — with
GitHub Actions
Error
GitHub Actions
Error
Shay Rojansky (roji)
force-pushed
the
SimplifySqlServer
branch
from
May 23, 2025 15:30
1c521b2 to
3416c17
Compare
Shay Rojansky (roji)
temporarily deployed
to
integration
May 23, 2025 15:31 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
westey (westey-m)
approved these changes
May 23, 2025
Eduard van Valkenburg (eavanvalkenburg)
pushed a commit
that referenced
this pull request
May 26, 2025
We currently write records to the database by first serializing them to a Dictionary, and then writing that Dictionary out as SqlParameters on the command. Similarly, we read records by allocating and populating a Dictionary, only to then iterate over that Dictionary and populate the .NET instance from it. This PR does away with the intermediate Dictionary representation. This optimizes serialization by removing the double-copy, reduces allocations, opens the way for boxing-free serialization, and also just simplifies the code (less conversions and stuff to follow).
jcruzmot-te
pushed a commit
to thousandeyes/aia-semantic-kernel
that referenced
this pull request
Sep 15, 2025
…t#12241) We currently write records to the database by first serializing them to a Dictionary, and then writing that Dictionary out as SqlParameters on the command. Similarly, we read records by allocating and populating a Dictionary, only to then iterate over that Dictionary and populate the .NET instance from it. This PR does away with the intermediate Dictionary representation. This optimizes serialization by removing the double-copy, reduces allocations, opens the way for boxing-free serialization, and also just simplifies the code (less conversions and stuff to follow).
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently write records to the database by first serializing them to a Dictionary, and then writing that Dictionary out as SqlParameters on the command. Similarly, we read records by allocating and populating a Dictionary, only to then iterate over that Dictionary and populate the .NET instance from it.
This PR does away with the intermediate Dictionary representation. This optimizes serialization by removing the double-copy, reduces allocations, opens the way for boxing-free serialization, and also just simplifies the code (less conversions and stuff to follow).
Part of #11123