Repository navigation
.Net: Fix BaseTest - #12208
Merged
Merged
.Net: Fix BaseTest#12208
Conversation
Tao Chen (TaoChenOSU)
temporarily deployed
to
integration
May 21, 2025 04:28 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Chris (crickman)
approved these changes
May 21, 2025
Chris (crickman)
approved these changes
May 21, 2025
Tao Chen (TaoChenOSU)
enabled auto-merge
May 21, 2025 17:07
Roger Barreto (rogerbarreto)
approved these changes
May 21, 2025
jcruzmot-te
pushed a commit
to thousandeyes/aia-semantic-kernel
that referenced
this pull request
Sep 15, 2025
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> We are seeing exceptions in some samples due to a bug in the `BaseTest.cs` module, that ignores the `modelName` parameter when creating a kernel with chat completion. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> This PR ensures that the `modelName` parameter is consistently passed to the `AddChatCompletionToKernel` method. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We are seeing exceptions in some samples due to a bug in the
BaseTest.csmodule, that ignores themodelNameparameter when creating a kernel with chat completion.Description
This PR ensures that the
modelNameparameter is consistently passed to theAddChatCompletionToKernelmethod.Contribution Checklist