Repository navigation
.Net MEVD: Update NRedisStack to 1.0.0 to get Full Framework fixes - #12163
Merged
Adam Sitnik (adamsitnik) merged 3 commits intoMay 19, 2025
Merged
Adam Sitnik (adamsitnik) merged 3 commits into
Adam Sitnik (adamsitnik) merged 3 commits into
Conversation
Mark Wallace (markwallace-microsoft)
added
.NET
Adam Sitnik (adamsitnik)
temporarily deployed
to
integration
May 19, 2025 13:04 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Adam Sitnik (adamsitnik)
requested review from
Shay Rojansky (roji) and
westey (westey-m)
May 19, 2025 13:10
| <PackageVersion Include="Pgvector" Version="0.3.1" /> | ||
| <PackageVersion Include="sqlite-vec" Version="0.1.7-alpha.2.1" /> | ||
| <PackageVersion Include="NRedisStack" Version="0.12.0" /> | ||
| <PackageVersion Include="NRedisStack" Version="1.0.0" /> |
Member
Author
There was a problem hiding this comment.
The number of test failures went from 82 to 4 after that (On Full Framework)
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' Or '$(TargetFramework)' == 'net462' "> | ||
| <PackageReference Include="Microsoft.Bcl.AsyncInterfaces" /> |
Member
Author
There was a problem hiding this comment.
it's not needed anymore, as it depends on System.Text.Json which has a dependency to Microsoft.Bcl.AsyncInterfaces
| => base.SpecialCharactersText; | ||
| #else | ||
| // Redis client doesn't properly escape '"' on Full Framework. | ||
| => """>with $om[ specia]chara<ters'and\stuff"""; |
Member
Author
There was a problem hiding this comment.
It's basically what the base class is using, except of "
…at base class returns
Adam Sitnik (adamsitnik)
temporarily deployed
to
integration
May 19, 2025 13:15 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
westey (westey-m)
approved these changes
May 19, 2025
Adam Sitnik (adamsitnik)
merged commit May 19, 2025
af2bd36
into
microsoft:feature-vector-data-preb3
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.