Repository navigation
Basically working VolatileMemoryStore - #1198
Merged
Mark Wallace (markwallace-microsoft) merged 2 commits intoMay 24, 2023
Merged
Mark Wallace (markwallace-microsoft) merged 2 commits into
Mark Wallace (markwallace-microsoft) merged 2 commits into
Conversation
Contributor
Author
|
This PR is a reboot of PR #1110. |
Lee Miller (lemillermicrosoft)
added
feature branch
Mark Wallace (markwallace-microsoft)
suggested changes
May 24, 2023
Mark Wallace (markwallace-microsoft)
left a comment
Mark Wallace (markwallace-microsoft)
left a comment
Contributor
There was a problem hiding this comment.
Take a look at the comment in DefaultSkillCollection
…ollection() public
Mark Wallace (markwallace-microsoft)
approved these changes
May 24, 2023
Mark Wallace (markwallace-microsoft)
merged commit May 24, 2023
688d4a4
into
microsoft:experimental-java
This was referenced Aug 1, 2023
John (johnoliver)
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Initial port of C# memory to Java. Includes VolatileMemoryStore, no others. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Introduces semantickernel-api/src/main/java/com/microsoft/semantickernel/memory and implementation in semantickernel-core/src/main/java/com/microsoft/semantickernel/memory e2e integration test provides a sample. See java/api-test/integration-tests/src/test/java/com/microsoft/semantickernel/e2e/TextEmbeddingsTest.java ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] -The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format`- Java code uses AOSP style - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
John (johnoliver)
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Initial port of C# memory to Java. Includes VolatileMemoryStore, no others. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Introduces semantickernel-api/src/main/java/com/microsoft/semantickernel/memory and implementation in semantickernel-core/src/main/java/com/microsoft/semantickernel/memory e2e integration test provides a sample. See java/api-test/integration-tests/src/test/java/com/microsoft/semantickernel/e2e/TextEmbeddingsTest.java ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] -The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format`- Java code uses AOSP style - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Initial port of C# memory to Java. Includes VolatileMemoryStore, no others.
Description
Introduces semantickernel-api/src/main/java/com/microsoft/semantickernel/memory and
implementation in semantickernel-core/src/main/java/com/microsoft/semantickernel/memory
e2e integration test provides a sample. See java/api-test/integration-tests/src/test/java/com/microsoft/semantickernel/e2e/TextEmbeddingsTest.java
Contribution Checklist
dotnet format- Java code uses AOSP style