Repository navigation
Make use of OpenAI SDK directly - #1197
Merged
Mark Wallace (markwallace-microsoft) merged 32 commits intoJun 9, 2023
Merged
Mark Wallace (markwallace-microsoft) merged 32 commits into
Mark Wallace (markwallace-microsoft) merged 32 commits into
Conversation
This reduces confusion with the Azure OpenAI SDK.
Member
Author
|
John (@johnoliver) there it goes. |
Mark Wallace (markwallace-microsoft)
added
the
java
Member
|
All fine, just need to resolve conflicts and update the samples |
Mark Wallace (markwallace-microsoft)
left a comment
Mark Wallace (markwallace-microsoft)
left a comment
Contributor
There was a problem hiding this comment.
LGTM
John (johnoliver)
previously approved these changes
May 25, 2023
Member
|
Bruno Borges (@brunoborges) has merge conflicts |
### Motivation and Context ### Description Opening a PR with initial CI changes to build and run tests against Java packages. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: joe-braley <[email protected]> Co-authored-by: Luigi96 <[email protected]> Co-authored-by: Mark Wallace <[email protected]>
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 Co-authored-by: Mark Wallace <[email protected]>
Mark Wallace (markwallace-microsoft)
added
the
PR: ready to merge
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Complete the implementation of VolatileMemoryStoreTests ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Complete the implementation of VolatileMemoryStoreTests. Make implementation consistent with tests. Please note that I added equals and hashCode methods to Embedding, MemoryRecord, and MemoryRecordMetadata because these unit tests use assertEquals. Alternatively, I could have created methods in VolatileMemoryStoreTests to check equality. I'm good with either way. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] ~The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format`~ Java code follows AOSP style - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Mark Wallace <[email protected]>
### Motivation and Context ### Description Add command to PRs to properly format Java code. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Mark Wallace <[email protected]>
Mark Wallace (markwallace-microsoft)
previously approved these changes
Jun 2, 2023
…nel into refactor-openai-sdk # Conflicts: # java/samples/pom.xml # java/semantickernel-connectors-parent/semantickernel-connectors/src/main/java/com/microsoft/semantickernel/connectors/ai/openai/textcompletion/OpenAITextCompletionBuilder.java # java/semantickernel-connectors-parent/semantickernel-connectors/src/main/java/com/microsoft/semantickernel/connectors/ai/openai/textembeddings/OpenAITextEmbeddingGenerationBuilder.java
Bruno Borges (brunoborges)
dismissed stale reviews from Mark Wallace (markwallace-microsoft) and John (johnoliver)
via
June 5, 2023 20:45
3bfea6f
Member
Author
|
Mark Wallace (@markwallace-microsoft) John (@johnoliver) Milder Hernandez (@milderhc) hey folks, this PR is 100% ready to go. |
Mark Wallace (markwallace-microsoft)
previously approved these changes
Jun 6, 2023
John (johnoliver)
previously approved these changes
Jun 6, 2023
github-actions
Bot
removed
python
Bruno Borges (brunoborges)
changed the title
…nel into refactor-openai-sdk
Adjust dependency on samples. Fix sample code imports.
Mark Wallace (markwallace-microsoft)
approved these changes
Jun 9, 2023
Mark Wallace (markwallace-microsoft)
merged commit Jun 9, 2023
70d49fe
into
microsoft:experimental-java
Mark Wallace (markwallace-microsoft)
pushed a commit
that referenced
this pull request
Jun 12, 2023
This is a follow up on the PR #1197
This was referenced Aug 1, 2023
John (johnoliver)
added a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
This PR removes the Azure Open AI Client wrapper originally created as a workaround. --------- Co-authored-by: Luigi Montoya <[email protected]> Co-authored-by: joe-braley <[email protected]> Co-authored-by: Luigi96 <[email protected]> Co-authored-by: Mark Wallace <[email protected]> Co-authored-by: John Oliver <[email protected]> Co-authored-by: David Grieve <[email protected]>
John (johnoliver)
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
) This is a follow up on the PR microsoft#1197
John (johnoliver)
added a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
This PR removes the Azure Open AI Client wrapper originally created as a workaround. --------- Co-authored-by: Luigi Montoya <[email protected]> Co-authored-by: joe-braley <[email protected]> Co-authored-by: Luigi96 <[email protected]> Co-authored-by: Mark Wallace <[email protected]> Co-authored-by: John Oliver <[email protected]> Co-authored-by: David Grieve <[email protected]>
John (johnoliver)
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
) This is a follow up on the PR microsoft#1197
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the Azure Open AI Client wrapper originally created as a workaround.