Skip to content

Python: Disable Milvus memory store integration tests - #11920

Merged
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit into
microsoft:mainfrom
TaoChenOSU:taochen/python-disable-milvus-memory-store-integration-test
May 7, 2025
Merged

Eduard van Valkenburg (eavanvalkenburg) merged 1 commit into
microsoft:mainfrom
TaoChenOSU:taochen/python-disable-milvus-memory-store-integration-test

Conversation

@TaoChenOSU

@TaoChenOSU Tao Chen (TaoChenOSU) commented May 6, 2025 •

Copy link
Copy Markdown
Contributor

Motivation and Context

The Milvus memory store integration tests have been failing, blocking some PR merges.

Description

Temporarily skipping the Milvus memory store integration test.

Contribution Checklist

@TaoChenOSU Tao Chen (TaoChenOSU) self-assigned this May 6, 2025
@TaoChenOSU Tao Chen (TaoChenOSU) added the docs and tests Improvements or additions to documentation label May 6, 2025
@TaoChenOSU Tao Chen (TaoChenOSU) added the python Pull requests for the Python Semantic Kernel label May 6, 2025
@TaoChenOSU
Tao Chen (TaoChenOSU) marked this pull request as ready for review May 6, 2025 20:49
@TaoChenOSU
Tao Chen (TaoChenOSU) requested a review from a team as a code owner May 6, 2025 20:49
@github-actions github-actions Bot changed the title Disable Milvus memory store integration tests Python: Disable Milvus memory store integration tests May 6, 2025
@TaoChenOSU
Tao Chen (TaoChenOSU) added this pull request to the merge queue May 7, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 7, 2025
Merged via the queue into microsoft:main with commit 7593c91 May 7, 2025
@github-project-automation github-project-automation Bot moved this to Sprint: Done in Semantic Kernel May 7, 2025
jcruzmot-te pushed a commit to thousandeyes/aia-semantic-kernel that referenced this pull request Sep 15, 2025
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
The Milvus memory store integration tests have been failing, blocking
some PR merges.

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
Temporarily skipping the Milvus memory store integration test.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
github-merge-queue Bot pushed a commit that referenced this pull request Dec 1, 2025
…3.0+ (#13396)

### Motivation and Context

Gemini 3.0 introduces a new `ThinkingLevel` string parameter with
values: "none", "low", "medium", "high". The existing `ThinkingBudget`
parameter remains valid for older Gemini 2.5 models.

Fixes #11920

### Description

- Added `ThinkingLevel` property to `GeminiThinkingConfig`
- Kept `ThinkingBudget` property as-is (still applicable for older
Gemini 2.5 models)
- Updated `GeminiRequestThinkingConfig` to serialize both properties
- Added unit tests for `ThinkingLevel` serialization and deserialization
- Converted `PromptExecutionSettingsCloneWorksAsExpected` to a Theory
that tests both `ThinkingBudget` and `ThinkingLevel` clone work as
expected
- Kept existing `ThinkingBudget` unit tests unchanged
- Renamed sample file to `Google_GeminiChatCompletionWithThinking.cs` to
demonstrate both APIs

**Usage:**
```csharp
// Gemini 3.0+
var settings = new GeminiPromptExecutionSettings
{
    ThinkingConfig = new GeminiThinkingConfig { ThinkingLevel = "high" }
};

// Gemini 2.5
var settings = new GeminiPromptExecutionSettings
{
    ThinkingConfig = new GeminiThinkingConfig { ThinkingBudget = 2000 }
};
```

### Contribution Checklist

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

<!-- START COPILOT CODING AGENT SUFFIX -->



<details>

<summary>Original prompt</summary>

> 
> ----
> 
> *This section details on the original issue you should resolve*
> 
> <issue_title>New Feature: .NET Gemini 3.0 Thinking Level
parameter</issue_title>
> <issue_description>---
> name: NET Gemini 3.0 Thinking Level parameter
> about: Gemini 3.0 Thinking parameter
> 
> ---
> 
> <!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
> <!-- Please read our Rules of Conduct:
https://opensource.microsoft.com/codeofconduct/ -->
> <!-- Please search existing issues to avoid creating duplicates. -->
> 
> <!-- Describe the feature you'd like. -->
> 
> In gemini 3.0 the thinking budget is depricated instead we have a new
parameter which is a string and its called ThinkingLevel where we can
specify what thinking level we want , high, low, default is high
> </issue_description>
> 
> <agent_instructions>Update GeminiThinkingConfig.cs to support
ThinkingLevel. Mark the existing ThinkingBudget parameter as
deprecated.</agent_instructions>
> 
> ## Comments on the Issue (you are @copilot in this section)
> 
> <comments>
> </comments>
> 


</details>

- Fixes #13377

<!-- START COPILOT CODING AGENT TIPS -->
---

💡 You can make Copilot smarter by setting up custom instructions,
customizing its development environment and configuring Model Context
Protocol (MCP) servers. Learn more [Copilot coding agent
tips](https://gh.io/copilot-coding-agent-tips) in the docs.

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: markwallace-microsoft <[email protected]>
Co-authored-by: rogerbarreto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs and tests Improvements or additions to documentation python Pull requests for the Python Semantic Kernel

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants