Repository navigation
.Net: Add cancellation token & add headers to request - #11900
Merged
SergeyMenshykh merged 3 commits intoMay 6, 2025
Merged
Conversation
Mark Wallace (markwallace-microsoft)
added
the
kernel
Roger Barreto (rogerbarreto)
approved these changes
May 6, 2025
westey (westey-m)
approved these changes
May 6, 2025
SergeyMenshykh
enabled auto-merge
May 6, 2025 10:19
github-project-automation
Bot
moved this from Sprint: In Review
to Sprint: Done
in Semantic Kernel
Chetan Desh (glorious-beard)
pushed a commit
to glorious-beard/semantic-kernel
that referenced
this pull request
May 6, 2025
### Motivation, Context and Description This PR: 1. Propagates the cancellation token from all kernel functions of the `SessionsPythonPlugin` plugin down to the APIs they call. 2. Refactors the way the plugin adds headers to the request. Instead of adding them as default headers of the HTTP client, they are now added as request headers. The result is the same - the headers are sent each call of any kernel function of the plugin. This change may save time later by preventing bug troubleshooting if/when an HTTP client is injected into the plugin and it sets default headers to the client it does not own. 3. Replaces the usage of HTTP client methods for getting content, such as `ReadAsStringAsync`, with the SK wrappers `ReadAsStringWithExceptionMappingAsync` to align the plugin's behavior with that of other SK components. Contributes to: microsoft#10070
jcruzmot-te
pushed a commit
to thousandeyes/aia-semantic-kernel
that referenced
this pull request
Sep 15, 2025
### Motivation, Context and Description This PR: 1. Propagates the cancellation token from all kernel functions of the `SessionsPythonPlugin` plugin down to the APIs they call. 2. Refactors the way the plugin adds headers to the request. Instead of adding them as default headers of the HTTP client, they are now added as request headers. The result is the same - the headers are sent each call of any kernel function of the plugin. This change may save time later by preventing bug troubleshooting if/when an HTTP client is injected into the plugin and it sets default headers to the client it does not own. 3. Replaces the usage of HTTP client methods for getting content, such as `ReadAsStringAsync`, with the SK wrappers `ReadAsStringWithExceptionMappingAsync` to align the plugin's behavior with that of other SK components. Contributes to: microsoft#10070
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation, Context and Description
This PR:
SessionsPythonPluginplugin down to the APIs they call.ReadAsStringAsync, with the SK wrappersReadAsStringWithExceptionMappingAsyncto align the plugin's behavior with that of other SK components.Contributes to: #10070