Repository navigation
.Net: replace custom delegates with Func - #11889
Closed
Adam Sitnik (adamsitnik) wants to merge 1 commit into
Closed
Adam Sitnik (adamsitnik) wants to merge 1 commit into
Adam Sitnik (adamsitnik) wants to merge 1 commit into
Conversation
Mark Wallace (markwallace-microsoft)
added
.NET
Adam Sitnik (adamsitnik)
temporarily deployed
to
integration
May 5, 2025 12:38 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
github-actions
Bot
changed the title
| /// The first <see cref="string"/> argument is the name of the vector to look up. | ||
| /// </para> | ||
| /// </remarks> | ||
| [Experimental("MEVD9000")] |
Member
Author
There was a problem hiding this comment.
I was not sure if [Experimental("MEVD9000")] was here because the delegates were experimental or if we want to remove the ability to resolve something in custom way in the long term.
Member
|
Let's discuss if we even want to keep the InMemory KeyResolver/VectorResolver. westey (@westey-m) Dmytro Struk (@dmytrostruk) what were the reasons for introducing these in the first place? Do we think we should keep them? |
Member
Author
|
See #11934 |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It addresses the concerns I've expressed in #11879 (comment)
To tell the long story short, there is no need to expose a new public type if we can just use
Func