Repository navigation
.Net: Remove concurrent "batching" implementations in MEVD - #11864
Merged
Shay Rojansky (roji) merged 3 commits intoMay 2, 2025
Merged
Shay Rojansky (roji) merged 3 commits into
Shay Rojansky (roji) merged 3 commits into
Conversation
Add default non-concurrent implementations for Get/Delete to VectorStoreCollection Closes microsoft#11854
Mark Wallace (markwallace-microsoft)
added
.NET
github-actions
Bot
changed the title
Shay Rojansky (roji)
had a problem deploying
to
integration
May 2, 2025 15:24 — with 
GitHub Actions
Failure
GitHub Actions
Failure
| { | ||
| Verify.NotNull(records); | ||
|
|
||
| (records, var generatedEmbeddings) = await ProcessEmbeddingsAsync(this._model, records, cancellationToken).ConfigureAwait(false); |
Contributor
There was a problem hiding this comment.
This is a nice improvement. The code feels much cleaner when it doesn't have these really long methods doing lots of different things.
Member
Author
There was a problem hiding this comment.
The long and complicated stuff is still there, but it's at least out of sight, yeah... I absolutely want to revisit and try to make this common across providers.
westey (westey-m)
approved these changes
May 2, 2025
Shay Rojansky (roji)
temporarily deployed
to
integration
May 2, 2025 17:21 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Dmytro Struk (dmytrostruk)
approved these changes
May 2, 2025
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11854