Skip to content

.Net: Remove Record from abstraction type names - #11832

Merged
Shay Rojansky (roji) merged 4 commits into
microsoft:feature-vector-data-preb3from
roji:Naming
May 2, 2025
Merged

.Net: Remove Record from abstraction type names #11832
Shay Rojansky (roji) merged 4 commits into
microsoft:feature-vector-data-preb3from
roji:Naming

Conversation

@roji

@roji Shay Rojansky (roji) commented May 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Note: this PR is based on top of #11823, review last commit only

This applies naming changes discussed in API review (plus some other minor ones which align). To avoid huge PRs, this only touches the abstraction types, and not implementation types (I'll do this in a later PR).

  • IVectorStoreRecordCollection -> IVectorStoreCollection
  • [VectorStoreRecordData] -> [VectorStoreData], [VectorStoreRecordVector] -> [VectorStoreVector]
    • This aligns with the vector definition type name, and also with us generally removing Record from names (i.e. this represents a "data property in a vector store" just like IVectorStoreCollection represents a "collection in a vector store").
    • I added property though we don't necessarily have to... These attributes define what the .NET property "is" in a sense (a vector property, a key property), so it makes sense to have a Property suffix (the previous VectorStoreRecordData/VectorStoreRecordVector was also not ideal since these aren't vectors (or "datas").

Part of #11230

@markwallace-microsoft Mark Wallace (markwallace-microsoft) added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel memory labels May 1, 2025
@github-actions github-actions Bot changed the title Remove Record from abstraction type names .Net: Remove Record from abstraction type names May 1, 2025
@roji
Shay Rojansky (roji) force-pushed the Naming branch 2 times, most recently from dbfcc44 to bf22ec7 Compare May 1, 2025 12:08
@roji
Shay Rojansky (roji) marked this pull request as ready for review May 1, 2025 12:24
@roji
Shay Rojansky (roji) requested a review from a team as a code owner May 1, 2025 12:24
@roji
Shay Rojansky (roji) merged commit f61f16a into microsoft:feature-vector-data-preb3 May 2, 2025
@roji
Shay Rojansky (roji) deleted the Naming branch May 2, 2025 13:31
@roji Shay Rojansky (roji) mentioned this pull request May 4, 2025
Merged
@roji Shay Rojansky (roji) linked an issue May 4, 2025 that may be closed by this pull request
.Net: [MEVD] Shorten IVectorStoreRecordCollection (and related) names #11230
Closed
Adam Sitnik (adamsitnik) pushed a commit that referenced this pull request May 5, 2025
@roji
.Net: Shorten MEVD implementation type names (#11879)
1d82e6c 
Following #11832, this shortens the names of provider implementation
types as discussed in API review (e.g.
AzureCosmosDBMongoDBVectorStoreRecordCollection ->
CosmosMongoCollection)

* For Cosmos, I've left CosmosMongo vs. CosmosNoSql (note lower-case Sql
rather than the previous SQL) to disambiguate, as discussed in API
review.
* We could also shorten PostgresVectorStore to PostgresStore (similar to
how we have PostgresCollection now). For now I'm leaving
PostgresVectorStore - we can discuss.
* No namespaces/nuget package names are touched - I'll do this in a
later PR.

Closes #11230

This branch was previously deployed

1 inactive deployment
integration — 5d364a02 Deployed May 2, 2025 by roji
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westey-m westey (westey-m) westey-m approved these changes

Assignees

No one assigned

Labels

kernel Issues or pull requests impacting the core kernel memory .NET Issue or Pull requests regarding .NET code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

.Net: [MEVD] Shorten IVectorStoreRecordCollection (and related) names

3 participants

@roji @westey-m @markwallace-microsoft