Skip to content

.Net: MEVD Feature Branch 3 - #11831

Merged
westey (westey-m) merged 72 commits into
mainfrom
feature-vector-data-preb3
May 19, 2025
Merged

.Net: MEVD Feature Branch 3#11831
westey (westey-m) merged 72 commits into
mainfrom
feature-vector-data-preb3

Conversation

@westey-m

@westey-m westey (westey-m) commented May 1, 2025

Copy link
Copy Markdown
Contributor

Motivation and Context

Feature branch PR containing all MEVD contributions

Description

Contribution Checklist

@markwallace-microsoft Mark Wallace (markwallace-microsoft) added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel memory labels May 1, 2025
@github-actions github-actions Bot changed the title MEVD Feature Branch 3 .Net: MEVD Feature Branch 3 May 1, 2025
@westey-m
.Net: MEVD: Add consistent error handling (#11845)
fb341a7 
### Motivation and Context

#11512
#11552

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Shay Rojansky (roji) and others added 9 commits May 2, 2025 13:54
@roji
.Net: Change Upsert to not return generated keys (#11853)
32fed50 
Closes #11835
@roji
.Net: Convert IVectorStore and IVectorStoreCollection from interfaces…
8273da3 
… to base classes (#11860)

Closes #11775
@roji
.Net: Remove concurrent "batching" implementations in MEVD (#11864)
39f9b82 
Closes #11854
@roji
.Net: Shorten MEVD implementation type names (#11879)
1d82e6c 
Following #11832, this shortens the names of provider implementation
types as discussed in API review (e.g.
AzureCosmosDBMongoDBVectorStoreRecordCollection ->
CosmosMongoCollection)

* For Cosmos, I've left CosmosMongo vs. CosmosNoSql (note lower-case Sql
rather than the previous SQL) to disambiguate, as discussed in API
review.
* We could also shorten PostgresVectorStore to PostgresStore (similar to
how we have PostgresCollection now). For now I'm leaving
PostgresVectorStore - we can discuss.
* No namespaces/nuget package names are touched - I'll do this in a
later PR.

Closes #11230
@roji
.Net: Pack of changes from MEVD API review (#11882)
472e1d5 
* Constrain TRecord to class
* Rename search interfaces
    * IVectorSearch -> IVectorSearchable
    * IKeywordHybridSearch -> IKeywordHybridSearchable
* Rename option bag types 
    * GetRecordOptions -> RecordRetrievalOptions
    * GetFilteredRecordOptions -> FilteredRecordRetrievalOptions
    * VectorSearchOptions -> RecordSearchOptions
* Make collection option types non-generic
* Make record definition property types mutable
* Rename ConnectorSupport -> ProviderServices
* Merge VectorStoreOperationException into VectorStoreException

Closes #11880
Closes #10879
@roji
.Net: Add covariant return types to VectorStore.GetCollection() imple…
280d98b 
…mentations (#11883)

Note that covariant return types are only supported in C# 9.0 and later,
so there's `#if`s in place for .NET Framework.

Closes #11759
@roji
.Net: Remove obsoleted MEVD APIs (#11891)
8e4d993 
This removes all MEVD obsolete APIs except for the legacy filters, which
are still required by SK's ITextSearch; this is tracked by #10456.

Closes #10809
@adamsitnik
.Net: Pincone cleanup (#11888)
881c69d 
we no longer provide a public PineconeClient type, so there is no need
to use fully qualified name when using the official Pincone types
@roji
.Net: Move strings from resx to a dedicated type (#11893)
a064d8d 
From API review.
@westey-m
westey (westey-m) marked this pull request as ready for review May 19, 2025 14:16
@westey-m
westey (westey-m) requested a review from a team as a code owner May 19, 2025 14:16
adamsitnik
Adam Sitnik (adamsitnik) approved these changes May 19, 2025
View reviewed changes

@adamsitnik Adam Sitnik (adamsitnik) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@westey-m
westey (westey-m) added this pull request to the merge queue May 19, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 19, 2025
@westey-m
westey (westey-m) added this pull request to the merge queue May 19, 2025
Merged via the queue into main with commit d72182f May 19, 2025
@westey-m
westey (westey-m) deleted the feature-vector-data-preb3 branch May 19, 2025 15:37
@westey-m
westey (westey-m) restored the feature-vector-data-preb3 branch May 19, 2025 15:50
@crickman
Chris (crickman) deleted the feature-vector-data-preb3 branch June 3, 2025 16:04
jcruzmot-te pushed a commit to thousandeyes/aia-semantic-kernel that referenced this pull request Sep 15, 2025
@westey-m @roji
@adamsitnik @dmytrostruk Javier
.Net: MEVD Feature Branch 3 (microsoft#11831)
4468bf8 
### Motivation and Context

Feature branch PR containing all MEVD contributions

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

---------

Co-authored-by: Shay Rojansky <[email protected]>
Co-authored-by: Adam Sitnik <[email protected]>
Co-authored-by: Dmytro Struk <[email protected]>

This branch was previously deployed

1 inactive deployment
integration — f194d0e1 Deployed May 19, 2025 by westey-m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roji Shay Rojansky (roji) roji approved these changes
@adamsitnik Adam Sitnik (adamsitnik) adamsitnik approved these changes
+1 more reviewer
@markwallace-microsoft Mark Wallace (markwallace-microsoft) markwallace-microsoft approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation kernel Issues or pull requests impacting the core kernel memory .NET Issue or Pull requests regarding .NET code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@westey-m @roji @adamsitnik @markwallace-microsoft @dmytrostruk