Repository navigation
.Net: Remove IMemoryStore and references to SK from MEVD - #11811
Merged
Shay Rojansky (roji) merged 1 commit intoApr 30, 2025
Merged
Shay Rojansky (roji) merged 1 commit into
Shay Rojansky (roji) merged 1 commit into
Conversation
Mark Wallace (markwallace-microsoft)
added
.NET
github-actions
Bot
changed the title
Shay Rojansky (roji)
had a problem deploying
to
integration
April 29, 2025 19:44 — with 
GitHub Actions
Failure
GitHub Actions
Failure
| @@ -1,5 +1,7 @@ | |||
| // Copyright (c) Microsoft. All rights reserved. | |||
|
|
|||
| #if DISABLED | |||
Member
Author
There was a problem hiding this comment.
westey (@westey-m) I've converted some other samples which show how to connect via MEVD to an IMemoryStore-created collection, but this one is slightly different since it shows an actual data migration... We should decide what we want to do with it (but can probably do it later?).
Shay Rojansky (roji)
force-pushed
the
RemoveObsolete
branch
from
April 29, 2025 20:36
995ab6d to
ce39e7c
Compare
Shay Rojansky (roji)
had a problem deploying
to
integration
April 29, 2025 20:36 — with
GitHub Actions
Failure
GitHub Actions
Failure
Shay Rojansky (roji)
force-pushed
the
RemoveObsolete
branch
from
April 30, 2025 07:09
ce39e7c to
e5ecaf7
Compare
Shay Rojansky (roji)
temporarily deployed
to
integration
April 30, 2025 07:10 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Shay Rojansky (roji)
marked this pull request as ready for review
April 30, 2025 07:21
Mark Wallace (markwallace-microsoft)
left a comment
Mark Wallace (markwallace-microsoft)
left a comment
Contributor
There was a problem hiding this comment.
Planning to talk to Shawn about this and the comms plan. Can we hold merging until this is worked out. Thanks.
Mark Wallace (markwallace-microsoft)
approved these changes
Apr 30, 2025
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the IMemoryStore implementations - and all supporting code - from all MEVD connectors. It also removes the reference to Microsoft.SemanticKernel.Core from the MEVD connectors.
Note that this doesn't remove IMemoryStore itself, and non-MEVD connectors (e.g. Chroma, Milvus) are untouched.
Closes #10855