Repository navigation
.Net: Fix Integration tests and a few small bugs. - #11778
Merged
westey (westey-m) merged 9 commits intoApr 28, 2025
Merged
westey (westey-m) merged 9 commits into
westey (westey-m) merged 9 commits into
Conversation
Mark Wallace (markwallace-microsoft)
added
.NET
github-actions
Bot
changed the title
westey (westey-m)
had a problem deploying
to
integration
April 28, 2025 17:29 — with 
GitHub Actions
Error
GitHub Actions
Error
westey (westey-m)
had a problem deploying
to
integration
April 28, 2025 17:32 — with
GitHub Actions
Failure
GitHub Actions
Failure
westey (westey-m)
changed the title
westey (westey-m)
had a problem deploying
to
integration
April 28, 2025 17:39 — with
GitHub Actions
Failure
GitHub Actions
Failure
westey (westey-m)
had a problem deploying
to
integration
April 28, 2025 17:54 — with
GitHub Actions
Error
GitHub Actions
Error
westey (westey-m)
had a problem deploying
to
integration
April 28, 2025 17:59 — with
GitHub Actions
Error
GitHub Actions
Error
westey (westey-m)
had a problem deploying
to
integration
April 28, 2025 18:04 — with
GitHub Actions
Failure
GitHub Actions
Failure
westey (westey-m)
changed the title
westey (westey-m)
temporarily deployed
to
integration
April 28, 2025 18:19 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
westey (westey-m)
temporarily deployed
to
integration
April 28, 2025 18:41 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
westey (westey-m)
temporarily deployed
to
integration
April 28, 2025 19:03 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Shay Rojansky (roji)
approved these changes
Apr 28, 2025
Shay Rojansky (roji)
left a comment
Shay Rojansky (roji)
left a comment
Member
There was a problem hiding this comment.
Mostly questions - definitely nothing blocking merging.
| _ => throw new UnreachableException() | ||
| } | ||
| : (ReadOnlyMemory<float>)property.GetValueAsObject(dataModel!)!)); | ||
| : (ReadOnlyMemory<float>?)property.GetValueAsObject(dataModel!)!)); |
Member
There was a problem hiding this comment.
I've wondered about this - so we fully support record with null embeddings?
Contributor
Author
There was a problem hiding this comment.
I don't think we have tests that check this end to end, so not sure, but here if someone just defines their embedding type as nullable this code throws, which is what this fix is about at least.
| } | ||
|
|
||
| this.SetPropertyStorageName(property, storageName); | ||
| this.SetPropertyStorageName(property, storageName, type); |
Member
There was a problem hiding this comment.
Small nit: can also have a dynamic bool parameter to make this a tiny bit more explicit.
Contributor
Author
There was a problem hiding this comment.
Yeah, let's change this later, the class needs more refactoring to not do this in other places too, and this isn't something I want to change at the last minute.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fix AzureAISearch tests and two small bugs.
Improve MongoDB tests with a small fix too.
Fix CosmosNoSQL integration tests
Fixes for postgres and mongodb
Fixes for redis
Contribution Checklist