Skip to content

Using BaseService as parent class for DocumentImportService - #1171

Merged
Adrian Bonar (adrianwyatt) merged 2 commits into
microsoft:mainfrom
teresaqhoang:extending-base-service
May 22, 2023
Merged

Adrian Bonar (adrianwyatt) merged 2 commits into
microsoft:mainfrom
teresaqhoang:extending-base-service

Conversation

@teresaqhoang

Copy link
Copy Markdown
Contributor

Motivation and Context

DocumentImportService needs to extend BaseService to get all the auth / header handling implemented in the parent.

@teresaqhoang Teresa Hoang (teresaqhoang) added the PR: ready to merge PR has been approved by all reviewers, and is ready to merge. label May 22, 2023
@adrianwyatt
Adrian Bonar (adrianwyatt) merged commit 143d30c into microsoft:main May 22, 2023
Shawn Callegari (shawncal) pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
…t#1171)

### Motivation and Context
DocumentImportService needs to extend BaseService to get all the auth /
header handling implemented in the parent.
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
…t#1171)

### Motivation and Context
DocumentImportService needs to extend BaseService to get all the auth /
header handling implemented in the parent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: ready to merge PR has been approved by all reviewers, and is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants