Repository navigation
.Net: Introduce a LINQ filter preprocessor in MEVD - #11702
Shay Rojansky (roji) merged 1 commit into
Conversation
Mark Wallace (markwallace-microsoft)
added
.NET
github-actions
Bot
changed the title
GitHub Actions
Failure
8b7eb32 to
1136556
Compare
GitHub Actions
Failure
| using System.Reflection; | ||
| using System.Runtime.CompilerServices; | ||
|
|
||
| namespace Microsoft.Extensions.VectorData.ConnectorSupport.Filter; |
There was a problem hiding this comment.
I would keep everything related to connector support under single Microsoft.Extensions.VectorData.ConnectorSupport namespace to avoid namespace explosion and for better discoverability.
1136556 to
9ef845e
Compare
GitHub Actions
Inactive
|
|
||
| default: | ||
| throw new NotSupportedException($"Member access for '{memberExpression.Member.Name}' is unsupported - only member access over the filter parameter are supported"); | ||
| this._filter.Append(property.StorageName); // TODO: Escape |
There was a problem hiding this comment.
Shay Rojansky (@roji) Dmytro Struk (@dmytrostruk) I fail to understand why this PR was reviewed and merged before #11676 which aims to solve the problem of escaping.
I did my best to ensure I review other people PRs first so everybody gets unblocked. As a result, I got none of my PRs reviewed, and all with merge conflicts. This is nice... not.
There was a problem hiding this comment.
Really sorry Adam Sitnik (@adamsitnik), I've been in a tunnel, focusing on my things, and I've neglected your PRs (and forgot that this would cause a conflict... I'm really sorry about that, my bad. I'll go review it now.
There was a problem hiding this comment.
I can also take care of the conflict resolution too, as it's my fault.
This is a refactor-only change, with no functional changes. It extracts out all logic for identifying and processing captured variables ("parameters") out to a new FilterTranslationProcessor connectos support type in MEVD.
This is preparatory work for #11673 (we need a centralized place to do this kind of thing).